Import Macro and personal.xlsb

[kmmsquared]

I am new to macros and trying to get this to pull data from another file, but it only imports the data into my personal.xls sheet and not the active sheet. I have checked that it is under a general module and not a worksheet in the personal.xls, but can't get it to work.

Suggestions?


Sub GetDataFromClosedWorkbook()
Dim wb As Workbook
Application.ScreenUpdating = False ' turn off the screen updating
Set Thiswb = Workbooks.Open("FileName", True, True)
' open the source workbook, read only
With ThisWorkbook.Worksheets("Sheet1")
' read data from the source workbook
.Range("A1:C29").Formula = Thiswb.Worksheets("Sheet1").Range("A1:C29").Formula
End With
Thiswb.Close False ' close the source workbook without saving any changes
Set Thiswb = Nothing ' free memory
Application.ScreenUpdating = True ' turn on the screen updating
End Sub

Thanks

 

[wigi]

Please run this macro and let us know the result in the MsgBox.

Sub GetDataFromClosedWorkbook()
    Dim wb As Workbook
    Application.ScreenUpdating = False    ' turn off the screen updating
    Set Thiswb = Workbooks.Open("FileName", True, True)
    ' open the source workbook, read only
    MsgBox ThisWorkbook.Name
    Thiswb.Close False    ' close the source workbook without saving any changes
    Set Thiswb = Nothing    ' free memory
End Sub

 

[kmmsquared]

Response is Personal.xlsb

 

[wigi]

There you got your response/error.

 

[kmmsquared]

I don't know how to fix the problem based on that...

 

[wigi]

Revise your post number 1, more specifically this sentence:

I have checked that it is under a general module and not a worksheet in the personal.xls

 

[kmmsquared]

Not finding edit button :S

 

[wigi]

I do not mean that you should change your initial post, I just wanted to say that you should paste the code in a module in the correct workbook. Or change the code so that the output is done in a different file.

 

[kmmsquared]

I'm sorry for being so vague in the initial post, I need help changing the code so that the output is done in an active workbook. I am very new to macros!

 

[wigi]

And the active workbook is the one you open with the code? Because that's what you'd have with your code.