input value for procesing - HELP! Please!

[miguel65]

Code:

Sub Delete_Rows()
Dim vFirstValue As Long
Dim vSecondValue As Long
Dim V1 As Long
Dim V2 As Long


Dim rng As Range

Set rng = Range("H5", Range("H" & Rows.Count).End(xlUp))

Application.ScreenUpdating = False
ActiveSheet.AutoFilterMode = False

vFirstValue = Application.InputBox(Prompt:="Enter Value 1", Type:=1)
vSecondValue = Application.InputBox(Prompt:="Enter Value 2", Type:=1)

Columns("H").AutoFilter Field:=1, Criteria1:="<V1=vFirstValue", Operator:=xlOr, Criteria2:=">V2=vSecondValue"

On Error Resume Next
rng.SpecialCells(xlCellTypeVisible).EntireRow.Delete
On Error GoTo 0

ActiveSheet.AutoFilterMode = False
Application.ScreenUpdating = True

End Sub

 

[GlennUK]

Is there a question to go with this code, or is everyone supposed to guess what is required?

 

[miguel65]

Code:

Sub Delete_Rows()
Dim vFirstValue As Long
Dim vSecondValue As Long
Dim V1 As Long
Dim V2 As Long


Dim rng As Range

Set rng = Range("H5", Range("H" & Rows.Count).End(xlUp))

Application.ScreenUpdating = False
ActiveSheet.AutoFilterMode = False

vFirstValue = Application.InputBox(Prompt:="Enter Value 1", Type:=1)
vSecondValue = Application.InputBox(Prompt:="Enter Value 2", Type:=1)

Columns("H").AutoFilter Field:=1, Criteria1:="<v1=vfirstvalue", operator:="xlOr," criteria2:=">V2=vSecondValue"

On Error Resume Next
rng.SpecialCells(xlCellTypeVisible).EntireRow.Delete
On Error GoTo 0

ActiveSheet.AutoFilterMode = False
Application.ScreenUpdating = True

End Sub

Hi guys,
I got this code that I worked on previously, it works fine if I do keep changing the values for criteria1 and criteria2 manually. But I am tired of changing them this way. So I thought as soon as I start running the VBA code I get prompted to give Value1 and Value2. The VBA does not crash but it does not do anything.
Thecode is meant to delete any entire row that does not have the expected value within the lowest (criteia1) and the highest value (criteria2).
"H" is the column where the analysed value will decide if the row gets deleted or not.

</v1=vfirstvalue",>

 

[miguel65]

Is there a question to go with this code, or is everyone supposed to guess what is required?

Sorry Glen for some reason the question with the code was not comming up write...so I had to split them in two lots...oopps

 

[GlennUK]

Your code was not in code tags, so I suspect that some of it is missing ... the most important bit actually ... the bit that specifies the criteria for the filter?

 

[miguel65]

Your code was not in code tags, so I suspect that some of it is missing ... the most important bit actually ... the bit that specifies the criteria for the filter?

Sub Delete_Rows()
    Dim vFirstValue As Long
    Dim vSecondValue As Long
    Dim V1 As Long
    Dim V2 As Long
    
    
    Dim rng As Range
    
    Set rng = Range("H5", Range("H" & Rows.Count).End(xlUp))

    Application.ScreenUpdating = False
    ActiveSheet.AutoFilterMode = False
    
    vFirstValue = Application.InputBox(Prompt:="Enter Value 1", Type:=1)
    vSecondValue = Application.InputBox(Prompt:="Enter Value 2", Type:=1)
    
    Columns("H").AutoFilter Field:=1, Criteria1:="<V1=vFirstValue", Operator:=xlOr, Criteria2:=">V2=vSecondValue"
    
    On Error Resume Next
    rng.SpecialCells(xlCellTypeVisible).EntireRow.Delete
    On Error GoTo 0
    
    ActiveSheet.AutoFilterMode = False
    Application.ScreenUpdating = True
     
End Sub

 

[miguel65]

Sub Delete_Rows()
    Dim vFirstValue As Long
    Dim vSecondValue As Long
    Dim V1 As Long
    Dim V2 As Long
    
    
    Dim rng As Range
    
    Set rng = Range("H5", Range("H" & Rows.Count).End(xlUp))
    Application.ScreenUpdating = False
    ActiveSheet.AutoFilterMode = False
    
    vFirstValue = Application.InputBox(Prompt:="Enter Value 1", Type:=1)
    vSecondValue = Application.InputBox(Prompt:="Enter Value 2", Type:=1)
    
    Columns("H").AutoFilter Field:=1, Criteria1:="<V1=vFirstValue", Operator:=xlOr, Criteria2:=">V2=vSecondValue"
    
    On Error Resume Next
    rng.SpecialCells(xlCellTypeVisible).EntireRow.Delete
    On Error GoTo 0
    
    ActiveSheet.AutoFilterMode = False
    Application.ScreenUpdating = True
     
End Sub

 

[miguel65]

I have tried a few times and the code gets chopped off
why?????

 

[miguel65]

I have tried a few times and the code gets chopped off
why?????

The mising bits are:

Colums ("H").AutoFilter Field:=1, Criteria:="V1=cFirstValue", Operator:=xlOr, Criteria2:=">V2=vSecondValue"

 

[GlennUK]

Just a guess, but maybe:

Columns("H").AutoFilter Field:=1, Criteria:=">=" & vFirstValue, Operator:=xlAnd, Criteria2:="<=" & vSecondValue