inputbox issues - looping through range twice

[scorpweb]

Hey All,

trying to format some data on multiple tabs

i've got select range selected via an input box as it varies each month. but the same range is required over 2 tabs.

I need to have the selected code to perform over both tabs 'ADL' and 'SYD'

can anyone advise why this isn't working or a workaround for it? do i need to set another rng variable for the 2nd tab? if so can i duplicate the inputbox result to this variable?

Sub percent2()

dim rng as range


Set rng = Application.InputBox(Prompt:="Range in Column I for the Month", Title:="Range Select", Type:=8)


For Each rng In rng



Worksheets("ADL").Activate
    If rng <> "" Then
rng.Value = Format((rng.Value / 100))
rng.NumberFormat = "0%"
rng.Offset(0, -1).Value = Format((rng.Offset(0, -1).Value / 100))
rng.Offset(0, -1).NumberFormat = "0%"
rng.Offset(0, -2).Value = Format((rng.Offset(0, -2).Value / 100))
rng.Offset(0, -2).NumberFormat = "0%"
rng.Offset(0, -3).Copy
rng.Offset(0, 1).PasteSpecial
End If
Next


Worksheets("SYD").Activate
    If rng <> "" Then


rng.Value = Format((rng.Value / 100))
rng.NumberFormat = "0%"
rng.Offset(0, -1).Value = Format((rng.Offset(0, -1).Value / 100))
rng.Offset(0, -1).NumberFormat = "0%"
rng.Offset(0, -2).Value = Format((rng.Offset(0, -2).Value / 100))
rng.Offset(0, -2).NumberFormat = "0%"
rng.Offset(0, -3).Copy
rng.Offset(0, 1).PasteSpecial
End If
Next
end sub

 

[Michael M]

Maybe this

Sub percent2()
Dim rng As Range, myary As Variant
myary = Array("ADL", "SYD")
Sheets(myary).Select
Set rng = Application.InputBox(Prompt:="Range in Column I for the Month", Title:="Range Select", Type:=8)
For Each rng In rng
If rng <> "" Then
rng.Value = Format((rng.Value / 100))
rng.NumberFormat = "0%"
rng.Offset(0, -1).Value = Format((rng.Offset(0, -1).Value / 100))
rng.Offset(0, -1).NumberFormat = "0%"
rng.Offset(0, -2).Value = Format((rng.Offset(0, -2).Value / 100))
rng.Offset(0, -2).NumberFormat = "0%"
rng.Offset(0, -3).Copy
rng.Offset(0, 1).PasteSpecial
End If
Next rng
Sheets("SYD").Select
End Sub

 

[scorpweb]

Maybe this

Sub percent2()
Dim rng As Range, myary As Variant
myary = Array("ADL", "SYD")
Sheets(myary).Select
Set rng = Application.InputBox(Prompt:="Range in Column I for the Month", Title:="Range Select", Type:=8)
For Each rng In rng
If rng <> "" Then
rng.Value = Format((rng.Value / 100))
rng.NumberFormat = "0%"
rng.Offset(0, -1).Value = Format((rng.Offset(0, -1).Value / 100))
rng.Offset(0, -1).NumberFormat = "0%"
rng.Offset(0, -2).Value = Format((rng.Offset(0, -2).Value / 100))
rng.Offset(0, -2).NumberFormat = "0%"
rng.Offset(0, -3).Copy
rng.Offset(0, 1).PasteSpecial
End If
Next rng
Sheets("SYD").Select
End Sub

Thanks Michael,

I tried it and it does select both worksheets but doesn't seem to apply the changes to any but the first Worksheet ("ADL") in this case. If i swap them around it applies it to SYD and not ADL.

any ideas?

 

[mikerickson]

The line

For Each rng In rng

looks fishy to me. I'm a bit surprised that it compiles.