Insert Images as Embedded Images

[mweick]

Hello, I am trying to insert these images in Excel 2010 but everytime I run this Macro they get inserted as linked images. Any advice?

<code style="margin: 0px; padding: 0px; border: 0px; font-family: Consolas, Menlo, Monaco, 'Lucida Console', 'Liberation Mono', 'DejaVu Sans Mono', 'Bitstream Vera Sans Mono', 'Courier New', monospace, sans-serif; white-space: inherit;"> Sub AddPictures()
Dim myPic As Picture
Dim wkSheet As Worksheet
Dim myRng As Range
Dim myCell As Range
Dim rowCount As Long
Dim rowCount2 As Long

Set wkSheet = Sheets(2) ' -- Change to your sheet

'-- The usual way of finding used row count for specific column
rowCount2 = wkSheet.Cells(wkSheet.Rows.Count, "C").End(xlUp).Row

If rowCount2 <> 0 Then
Set myRng = wkSheet.Range("C2", wkSheet.Cells(wkSheet.Rows.Count, "C").End(xlUp))

For Each myCell In myRng.Cells
If Trim(myCell.Value) = "" Then
MsgBox "No file path"
ElseIf Dir(CStr(myCell.Value)) = "" Then
MsgBox myCell.Value & " Doesn't exist!"
Else
myCell.Offset(0, 1).Parent.Pictures.Insert (myCell.Value)

With myCell.Offset(0, 1) '1 columns to the right of C ( is D)
'-- resize image here to fit into the size of your cell
myPic.Top = .Top
myPic.Left = .Left
myPic.Placement = xlMoveAndSize
End With
End If
Next myCell

Else
MsgBox "There is no file paths in your column"
End If
End Sub</code>

 

[mweick]

It doesn't like the myPic.Top = .Top and myPic.Left = .left - I removed these 2 lines and...

Here is an updated look at the script and its succesfully pulling in all the images now but they layered on top of each other in the top left of the sheet and not in the respective rows...

Sub AddPictures()
 Dim myPic As Picture
 Dim wkSheet As Worksheet
 Dim myRng As Range
 Dim myCell As Range
 Dim rowCount As Long
 Dim rowCount2 As Long


     Set wkSheet = Sheet1


    rowCount2 = wkSheet.Cells(wkSheet.Rows.Count, "G").End(xlUp).Row


    If rowCount2 <> 0 Then
        Set myRng = wkSheet.Range("G2", wkSheet.Cells(wkSheet.Rows.Count, "G").End(xlUp))


        For Each myCell In myRng.Cells
               If Trim(myCell.Value) = "" Then
                    MsgBox "No file path"
               ElseIf Dir(CStr(myCell.Value)) = "" Then
                    MsgBox myCell.Value & " Doesn't exist!"
               Else
                    myCell.Offset(0, 1).Parent.Shapes.AddPicture(myCell.Value, False, True, -1, -1, -1, -1).Select
               
               With myCell.Offset(0, 1)
                    
                    End With
               
               End If
        Next myCell


    Else
        MsgBox "There is no file paths in your column"
    End If
End Sub

 

[Smitty]

You're selecting after adding the image, not before.

Try selecting the destination cell first, then adding the image.

 

[mweick]

I'm trying to understand why it didn't like the myPic.Top = .Top and myPic.Left = .Left

This is how it put the image in the proper cell and when I update the code with you suggestion it didn't like the myPic location definitions anymore.

Do I have to define it differently with this line?

 

[Smitty]

You'd need to post the code that you're using now.

Note that I'm outta' here for a few days in the morning, so hopefully someone else can pitch in.