Logic question

[AlexanderBB]

I'm having bit of brainfade, I think !

Private p As String
Private d As String
Private m As String
The value I want to assign is returned by Designations("m/") or "p/" etc.

Function Designations(d As String) As Variant
    Designations = Switch(d = "p/", "Producer:", d = "o/", "Orchestra:", d = "m/", "Movie Or Musical:")
End Function

Do I need for example, m= Designations("m/"), repeated for every case, or can I somehow handle it with one line regardless of value "m/" or "d/" or "p/"

 

[Rick Rothstein]

The Switch function is not a very efficient function. How about something like this...

[table="width: 500"]
[tr]
	[td]Function Designations(d As String) As Variant
  Dim Arr As Variant
  Arr = Array("p/Producer:", "o/Orchestra:", "m/Movie Or Musical:")
  Designations = Mid(Filter(Arr, d, True, vbTextCompare)(0), 3)
End Function[/td]
[/tr]
[/table]

While harder to read, you can make the above a one-liner (if that is what the intent behind your posted code was trying to project that you wanted)...

[table="width: 500"]
[tr]
	[td]Function Designations(d As String) As Variant
  Designations = Mid(Filter(Array("p/Producer:", "o/Orchestra:", "m/Movie Or Musical:"), d, True, vbTextCompare)(0), 3)
End Function[/td]
[/tr]
[/table]

 

[AlexanderBB]

Thanks Rick, I've binned all the switch stuff and changed to what you suggested.
Cheers, Alex