Long Loop

[Lester601]

Can anyone tell me why this loop takes so long with 600 emps?


For varcounter = 1 To varNbEmployees

A = ActiveCell.address
Range(A).Select
ActiveCell.Value = ActiveCell.Offset(0, 2).Value & ActiveCell.Offset(0, 3).Value & ActiveCell.Offset(0, 4).Value
ActiveCell.Offset(1, 0).Select

Next varcounter

 

[Norie]

I don't know if it helps but you don't need to use Select.

Dim rng As Range

Set rng = ActiveCell

For varcounter = 1 To varNbEmployees

    rng.Value = rng.Offset(0, 2).Value & rng.Offset(0, 3).Value & rng.Offset(0, 4).Value
    Set rng = rng.Offset(1, 0)

Next varcounter

By the way can't you do this using worksheet functions rather than VBA?

 

[PA HS Teacher]

It think its because your selecting 600 times. Usually the less you select, the faster code runs.

iStartCol = Range("A1").Column
iStartRow = Range("A1").Row

For i = iStartRow to iStartRow+ varNbEmployees
   Cells(i, iStartCol).Value = Cells(i,iStartCol+2).Value &  Cells(i,iStartCol+3).Value & Cells(i,iStartCol+4).Value
Next i