Loop still running?

[davidam]

Hello,
I am using variable x to end a loop as follows:

Dim x As Integer
x = 1
Set portColumn = ThisWorkbook.Worksheets("Web").Range("U69")
Do Until x = 5
Call GoGetData
Call CleanNewData
Call MakeNewFile
Set portColumn = portColumn.Offset(0, 2)
x = x + 1
Loop

This works fine. There are 4 blocks of data to process; the last line of the last Sub is completed properly, after the 4th block of data. Everything stops at the right time except that the module continues to say "running" and I need to press the stop button to get rid of this. Any suggestions? Many thanks.
David

 

[ukmikeb]

Hi

Try -

Dim x As Integer
x = 1
Set portColumn = ThisWorkbook.Worksheets("Web").Range("U69")
Do 
    Call GoGetData
    Call CleanNewData
    Call MakeNewFile
    Set portColumn = portColumn.Offset(0, 2)
    x = x + 1
Loop Until x = 5

hth

 

[Biz]

Try Code below

Sub Test()
Dim x As Integer

For x = 1 to 5
Set portColumn = ThisWorkbook.Worksheets("Web").Range("U69")

Call GoGetData
Call CleanNewData
Call MakeNewFile
Set portColumn = portColumn.Offset(0, 2)
Next X
 
End Sub

 

[davidam]

I have tried these methods and they do seem to be more reliable. Thank you.

 

[ukmikeb]

Hi

Pleased to have helped solve your problem.

Thanks for the feedback.

Good luck with your project.