loop until confusing

[zmhnk]

hi ...

i have form with combo box and button add when i choose the name form combo box and press add the form work good, what i need is, when the user didnt choose one of the values from combobox and hit the button add, msg will show to user "Please choose one value from combo box " ,

and the msg will disappear when the user choose the value from combo box and hit add button

i try something like this :

[COLOR=Red][B]
if (CmbNames.value="") then
do
loop until (CmbNames.value<>"")
msgbox [COLOR=DeepSkyBlue]"Please choose one value from combo box " [/COLOR]
end if 
loop[/B][/COLOR]

so what is the wrong ???/

 

[krausr79]

If they are to press a button , then what about putting the macro in the button press. Start it with

if (CmbNames.value="") then exit sub

 

[xenou]

^^ Correct. Just use the button click event, not a do loop.

Sub Button1_Click()

If Len(CmbNames.value)=0 then
    Exit Sub 
Else
    'Do stuff
End If

End Sub

I use the Len() function by habit to account for null values and zero-length strings indifferently. That may be overkill here but in any case that's my tried and true for testing for blanks/nulls/empty strings etc.

 

[AlphaFrog]

You could Enable\Disable the Add button (btnAdd) if the combobox (CmbNames) has a value.

Set the default property of the button to Enabled = False.

Then this will set the enabled propery to true if the combobox has a value.

Private Sub CmbNames_Change()
    btnAdd.Enabled = CmbNames.Value <> ""
End Sub

 

[zmhnk]

thnx for ur help but i want the msg shown if the combobox is null ?????

 

[zmhnk]

thnx guys for all ur help , but i want the msg appear when the string is empty until the string is not empty

 

[xenou]

Just put an asterisk by the combobox:

Enter XXX (*Required): ____________


User doesn't need a message box to know if a value is entered since that can be seen without a message box or handled on the button click event. In any case, VBA message boxes are modal and would prevent a value being selected (they wouldn't be able to select any value while the message box is showing, but the message would show as long as they haven't selected a value, so it becomes an infinite loop with no exit point).