Looping through rows and then by columns

Taul

Well-known Member
Joined
Oct 24, 2004
Messages
767
Office Version
  1. 2019
Platform
  1. Windows
Hi,
I could do with some assistance please. I have data laid out as follows:-
Headers in row 5 and Data in columns A to T (approx. 300 rows of data)
Column A will always shave data in it, so I’m using that column to reference the “lastrow”
Columns G to K will have company names (with some blank) and I need to loop through column G and for each occurrence of data (a company name) I need to paste the company name in the next available row in column F and then repeat for columns H, I J & K
The code I have so far works for the first column but using the offset command pastes the wrong data to column A to E
Can anyone assist in getting a loop within a loop to work correctly please.
I have a feeling it may involve using two variable j & i but I can’t figure that out.

The blue text is not working, so ...
Up to Row 12 is the source data,
Row 13 and below is what is required after the macro is run (should have been blue)


Excel 2010
ABCDEFGHIJK
5DateModuleNameCategoryProjectFab 1Fab 2Fab 3Fab 4Fab 5Fab 6
619-04-18R1GWABWProject 1Fab 1Fab 2
724-04-18R1GWABWProject 2Fab 2
825-04-18R3MCKRYProject 3Fab 3Fab 6Fab 9
911-04-18R4AFCVProject 4Fab 2Fab 3
1011-04-18R4AFCVProject 5Fab 5Fab 7Fab 6
1112-04-18R4AFCVProject 6Fab 6Fab 2
1216-04-18R4AFCVProject 7Fab 7
1319-04-18Row 6GWABWProject 1Fab 2
1425-04-18Row 8MCKRYProject 3Fab 6
1511-04-18Row 9AFCVProject 4Fab 3
1611-04-18Row 10AFCVProject 5Fab 7
1712-04-18Row 11AFCVProject 6Fab 2
1825-04-18Row 8MCKRYProject 3Fab 9
1911-04-18Row 10AFCVProject 5Fab 6
20
21After macro runs, the data in BLUE should be pasted

<tbody>
</tbody>
Sheet1


Code:
Sub AlignFabs()
'Application.ScreenUpdating = False
'Application.Calculation = xlCalculationManual
''**** Loop Through Rows of Fab Names ****
For Each Col In Array("G", "H", "I", "J", "K")
cntr = 0
 
For Each co In Sheet1.Range(Col & "6:" & Col & Sheet1.Range(Col & "65536").End(xlUp).Row + 0)
    lastrow = Sheet1.Range("A65536").End(xlUp).Offset(1, 0).Row 'define the row increment on the Destination sheet
   
    If co.Offset(0, 0).Value <> "" Then
        Sheet1.Range("A" & lastrow).Value = co.Offset(0, -6) 'Date
        Sheet1.Range("B" & lastrow).Value = "Copy" 'ideally paste the row number it came from
        Sheet1.Range("C" & lastrow).Value = co.Offset(0, -4) 'Name
        Sheet1.Range("D" & lastrow).Value = co.Offset(0, -3) 'Category
        Sheet1.Range("E" & lastrow).Value = co.Offset(0, -2) 'Project
        Sheet1.Range("F" & lastrow).Value = co.Offset(0, 0) 'Fab1 column F
    End If
cntr = cntr + 1
Next co
Next Col
'Application.Calculation = xlCalculationAutomatic
'Application.ScreenUpdating = True
End Sub
 

Excel Facts

Create a chart in one keystroke
Select the data and press Alt+F1 to insert a default chart. You can change the default chart to any chart type
How about
Code:
Sub AlignFabs()
Dim cntr As Long
'Application.ScreenUpdating = False
'Application.Calculation = xlCalculationManual
''**** Loop Through Rows of Fab Names ****
cntr = 0

For Each col In Array("G", "H", "I", "J", "K")
 
For Each Co In Sheet6.Range(col & "6:" & col & Sheet6.Range(col & "65536").End(xlUp).Row + 0)
    lastRow = Sheet6.Range("A65536").End(xlUp).Offset(1, 0).Row 'define the row increment on the Destination sheet
   
    If Co.Offset(0, 0).Value <> "" Then
        Sheet6.Range("A" & lastRow).Value = Co.Offset(0, -6 - cntr) 'Date
        Sheet6.Range("B" & lastRow).Value = "Copy" 'ideally paste the row number it came from
        Sheet6.Range("C" & lastRow).Value = Co.Offset(0, -4 - cntr) 'Name
        Sheet6.Range("D" & lastRow).Value = Co.Offset(0, -3) 'Category
        Sheet6.Range("E" & lastRow).Value = Co.Offset(0, -2) 'Project
        Sheet6.Range("F" & lastRow).Value = Co.Offset(0, 0) 'Fab1 column F
    End If
Next Co
cntr = cntr + 1
Next col
'Application.Calculation = xlCalculationAutomatic
'Application.ScreenUpdating = True
End Sub
 
Upvote 0
Solution
Thank you Fluff,
I hadn't thought of -cntr, good call.
I will check it out on Monday when I return to work.

Many thanks
Paul
 
Upvote 0
Do the extra rows need to go at the bottom of the data, or would you be happy with inserting new rows below the existing rows, like


Excel 2013 32 bit
ABCDEFGHIJKL
15DateModuleNameCategoryProjectFab 1Fab 2Fab 3Fab 4Fab 5Fab 6
2619/04/2018R1GWABWProject 1Fab 1Fab 2
3719/04/2018R1GWABWProject 1Fab 2
4824/04/2018R1GWABWProject 2Fab 2
5925/04/2018R3MCKRYProject 3Fab 3Fab 6Fab 9
61025/04/2018R3MCKRYProject 3Fab 6
71125/04/2018R3MCKRYProject 3Fab9
Combined
 
Upvote 0
If you are interested in the above idea, try
Code:
 Sub TransposeData()
   Dim Cl As Range
   Dim Rws As Long
   Dim i As Long
   
   For i = Range("A" & Rows.Count).End(xlUp).Row To 6 Step -1
      Rws = Application.CountA(Range("G" & i).Resize(, 5))
      If Rws > 0 Then
         Rows(i + 1).Resize(Rws).Insert
         Range("A" & i).Resize(Rws + 1, 5).FillDown
         Range("F" & i + 1).Resize(Rws).Value = Application.Transpose(Range("G" & i).Resize(, Rws))
      End If
   Next i
  [COLOR=#ff0000] Range("G:K").Clear[/COLOR]
 End Sub
Remove the line in red if you want to keep the data in cols G:K
 
Upvote 0
Thank you Fluff,
That's an interesting approach that I hadn't considered.
Just to put more meat on the bones, this whole report is connecting to a shared Outlook Calendar and pulling in all the appointments between specified dates. The Appointment form in Outlook has a custom page with additional drop-downs and text boxes. So the Excel report page (a sample section of it is shown on the original post) also has other formula that are applied at the run time and feed into other pages and graphs on the report, so although your approach is sensible, making the change at this stage would involve making loads of changes to the way the whole report runs. I think your suggestion has now made me realise that I could have laid it out better but I think I will stick to my current approach, if only to avoid the pain of changing it.
But I really appreciate the assistance you have provided.

I may feel different on Monday morning when I run this and with the benefit of a weekend off, I may adopt your approach.

cheers
Paul.
 
Upvote 0
That's fair enough.
Let me know how it goes.
 
Upvote 0

Forum statistics

Threads
1,214,957
Messages
6,122,472
Members
449,087
Latest member
RExcelSearch

We've detected that you are using an adblocker.

We have a great community of people providing Excel help here, but the hosting costs are enormous. You can help keep this site running by allowing ads on MrExcel.com.
Allow Ads at MrExcel

Which adblocker are you using?

Disable AdBlock

Follow these easy steps to disable AdBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the icon in the browser’s toolbar.
2)Click on the "Pause on this site" option.
Go back

Disable AdBlock Plus

Follow these easy steps to disable AdBlock Plus

1)Click on the icon in the browser’s toolbar.
2)Click on the toggle to disable it for "mrexcel.com".
Go back

Disable uBlock Origin

Follow these easy steps to disable uBlock Origin

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back

Disable uBlock

Follow these easy steps to disable uBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back
Back
Top