Macro problem

[Noz2k]

I have 2 command buttons, 1 which opens a userform and enables the user to scroll through the records and amend them, and another which opens the userform but only allows the user to make a new entry.

This is done by enabling/disabling a combobox.

The problem I am having is that I have to seemingly run the macro twice for it to take effect. Any ideas why this might be?

Here are the 2 codes

Editable

Sub ViewForm()
Dim pword As String
pword = InputBox("Please enter the password:")
If pword <> "mypassword" Then
MsgBox "Incorrect password"
Else
 
UserForm1.Show
 
End If
End Sub

Create New only

Sub NewForm()
UserForm1.Show
UserForm1.cboAccidentID.Enabled = False
End Sub

 

[JamesW]

Hi Noz,

Which macro do you have to run twice? Both of them?

Have you tried Enabling the combobox in the ViewForm Sub?

 

[Noz2k]

Yes both of them.

I have, but the only difference it makes is that when I then close the form it generates an error on that line "cboAccidentID.Enabled = True"

"Run-time error '424':

Object Required"

Edit: Apologies that was because the line should have been UserForm1.cboAccidentID.Enabled = True

So no error now, but still have to run the macros twice

 

[Noz2k]

So I had a couple of Me.EnableEvents in my Userform_Initialize which didn't need to be there (I'd left them from something I tried earlier).

So now it works, but strangely the wrong way around where

.Enabled = False, it seems to be enabled

and where

.Enabled = True, it seems to be disabled

 

[JamesW]

Ahh I see now. Swap the cbo enabled line with the userform.show line:

    Dim pword As String
        pword = InputBox("Please enter the password:")
    If pword <> "a" Then
        MsgBox "Incorrect password"
    Else
        UserForm1.cboAccidentID.Enabled = True
        UserForm1.Show
    End If

    UserForm1.cboAccidentID.Enabled = False
    UserForm1.Show

 

[Noz2k]

That works perfect, thanks James