Making a sub to make code more readable.

adsxvii

adsxvii

Board Regular
Joined
Mar 15, 2007
Messages
213
Hi my code is like this:
Code: 
If .Range("H1") <> "" Then
                If .Range("H1") > 50 Then
                    If Right(Sheets("Daily").Range("BM" & CurOutRow), 1) <> "T" And Right(Sheets("Daily").Range("BM" & CurOutRow + 1), 1) <> "T" Then
                        If Sheets("Daily").Range("AW" & CurOutRow) = "" Then
                            .Range("G1:J1").Copy
                            Sheets("Daily").Cells(CurOutRow, Range("AW1").Column).PasteSpecial Paste:=xlPasteValues, _
                                                Operation:=xlNone, SkipBlanks:=True, Transpose:=False
                            Sheets("Daily").Range("BM" & CurOutRow) = Left(SheetName(Primary), 1) & "T"
                        End If
                        If Right(Sheets("Daily").Range("BM" & CurOutRow + 1), 1) = "S" Then
                            .Range("G2:J2").Copy
                            Sheets("Daily").Cells(CurOutRow + 1, Range("AW2").Column).PasteSpecial Paste:=xlPasteValues, _
                                                Operation:=xlNone, SkipBlanks:=True, Transpose:=False
                            Sheets("Daily").Range("BM" & CurOutRow + 1) = Left(SheetName(Primary), 1) & "T"
                        End If
                    End If
                End If
                If .Range("H1") < 50 Then
                    If Right(Sheets("Daily").Range("BM" & CurOutRow), 1) <> "S" And Right(Sheets("Daily").Range("BM" & CurOutRow + 1), 1) <> "S" Then
                        If Sheets("Daily").Range("AW" & CurOutRow) = "" Then
                            .Range("G1:J1").Copy
                            Sheets("Daily").Cells(CurOutRow, Range("AW1").Column).PasteSpecial Paste:=xlPasteValues, _
                                                Operation:=xlNone, SkipBlanks:=True, Transpose:=False
                            Sheets("Daily").Range("BM" & CurOutRow) = Left(SheetName(Primary), 1) & "S"
                        End If
                        If Right(Sheets("Daily").Range("BM" & CurOutRow + 1), 1) = "T" Then
                            .Range("G2:J2").Copy
                            Sheets("Daily").Cells(CurOutRow + 1, Range("AW2").Column).PasteSpecial Paste:=xlPasteValues, _
                                                Operation:=xlNone, SkipBlanks:=True, Transpose:=False
                            Sheets("Daily").Range("BM" & CurOutRow + 1) = Left(SheetName(Primary), 1) & "S"
                        End If
                    End If
                End If
            End If
            
            If .Range("H2") <> "" Then
                If .Range("H2") > 50 Then
                    If Right(Sheets("Daily").Range("BM" & CurOutRow), 1) <> "T" And Right(Sheets("Daily").Range("BM" & CurOutRow + 1), 1) <> "T" Then
                        If Sheets("Daily").Range("AW" & CurOutRow + 1) = "" Then
                            .Range("G2:J2").Copy
                            Sheets("Daily").Cells(CurOutRow + 1, Range("AW2").Column).PasteSpecial Paste:=xlPasteValues, _
                                                Operation:=xlNone, SkipBlanks:=True, Transpose:=False
                            Sheets("Daily").Range("BM" & CurOutRow + 1) = Left(SheetName(Primary), 1) & "T"
                        End If
                        If Right(Sheets("Daily").Range("BM" & CurOutRow), 1) = "S" Then
                            .Range("G2:J2").Copy
                            Sheets("Daily").Cells(CurOutRow, Range("AW2").Column).PasteSpecial Paste:=xlPasteValues, _
                                                Operation:=xlNone, SkipBlanks:=True, Transpose:=False
                            Sheets("Daily").Range("BM" & CurOutRow) = Left(SheetName(Primary), 1) & "T"
                        End If
                    End If
                End If
                If .Range("H2") < 50 Then
                    If Right(Sheets("Daily").Range("BM" & CurOutRow), 1) <> "S" And Right(Sheets("Daily").Range("BM" & CurOutRow + 1), 1) <> "S" Then
                        If Sheets("Daily").Range("AW" & CurOutRow + 1) = "" Then
                            .Range("G2:J2").Copy
                            Sheets("Daily").Cells(CurOutRow + 1, Range("AW2").Column).PasteSpecial Paste:=xlPasteValues, _
                                                Operation:=xlNone, SkipBlanks:=True, Transpose:=False
                            Sheets("Daily").Range("BM" & CurOutRow + 1) = Left(SheetName(Primary), 1) & "S"
                        End If
                        If Right(Sheets("Daily").Range("BM" & CurOutRow), 1) = "T" Then
                            .Range("G2:J2").Copy
                            Sheets("Daily").Cells(CurOutRow, Range("AW2").Column).PasteSpecial Paste:=xlPasteValues, _
                                                Operation:=xlNone, SkipBlanks:=True, Transpose:=False
                            Sheets("Daily").Range("BM" & CurOutRow) = Left(SheetName(Primary), 1) & "S"
                        End If
                    End If
                End If
            End If
            
            If .Range("M1") <> "" Then
                If .Range("M1") > 50 Then
                    If Right(Sheets("Daily").Range("BO" & CurOutRow), 1) <> "T" And Right(Sheets("Daily").Range("BO" & CurOutRow + 1), 1) <> "T" Then
                        If Sheets("Daily").Range("BG" & CurOutRow) = "" Then
                            .Range("L1:O1").Copy
                            Sheets("Daily").Cells(CurOutRow, Range("BG1").Column).PasteSpecial Paste:=xlPasteValues, _
                                                Operation:=xlNone, SkipBlanks:=True, Transpose:=False
                            Sheets("Daily").Range("BO" & CurOutRow) = Left(SheetName(Primary), 1) & "T"
                        End If
                        If Right(Sheets("Daily").Range("BO" & CurOutRow + 1), 1) = "S" Then
                            .Range("G2:J2").Copy
                            Sheets("Daily").Cells(CurOutRow, Range("AW2").Column).PasteSpecial Paste:=xlPasteValues, _
                                                Operation:=xlNone, SkipBlanks:=True, Transpose:=False
                            Sheets("Daily").Range("BO" & CurOutRow + 1) = Left(SheetName(Primary), 1) & "T"
                        End If
                    End If
                End If
                If .Range("M1") < 50 Then
                    If Right(Sheets("Daily").Range("BO" & CurOutRow), 1) <> "S" And Right(Sheets("Daily").Range("BO" & CurOutRow + 1), 1) <> "S" Then
                        If Sheets("Daily").Range("BG" & CurOutRow) = "" Then
                            .Range("L1:O1").Copy
                            Sheets("Daily").Cells(CurOutRow, Range("BG1").Column).PasteSpecial Paste:=xlPasteValues, _
                                                Operation:=xlNone, SkipBlanks:=True, Transpose:=False
                            Sheets("Daily").Range("BO" & CurOutRow) = Left(SheetName(Primary), 1) & "S"
                        End If
                        If Right(Sheets("Daily").Range("BO" & CurOutRow + 1), 1) = "T" Then
                            .Range("G2:J2").Copy
                            Sheets("Daily").Cells(CurOutRow, Range("AW2").Column).PasteSpecial Paste:=xlPasteValues, _
                                                Operation:=xlNone, SkipBlanks:=True, Transpose:=False
                            Sheets("Daily").Range("BO" & CurOutRow + 1) = Left(SheetName(Primary), 1) & "S"
                        End If
                    End If
                End If
            End If
            
            If .Range("M2") <> "" Then
                If .Range("M2") > 50 Then
                    If Right(Sheets("Daily").Range("BO" & CurOutRow), 1) <> "T" And Right(Sheets("Daily").Range("BO" & CurOutRow + 1), 1) <> "T" Then
                        If Sheets("Daily").Range("BG" & CurOutRow + 1) = "" Then
                            .Range("L2:O2").Copy
                            Sheets("Daily").Cells(CurOutRow + 1, Range("BG1").Column).PasteSpecial Paste:=xlPasteValues, _
                                                Operation:=xlNone, SkipBlanks:=True, Transpose:=False
                            Sheets("Daily").Range("BO" & CurOutRow + 1) = Left(SheetName(Primary), 1) & "T"
                        End If
                        If Right(Sheets("Daily").Range("BO" & CurOutRow), 1) = "S" Then
                            .Range("G2:J2").Copy
                            Sheets("Daily").Cells(CurOutRow, Range("AW2").Column).PasteSpecial Paste:=xlPasteValues, _
                                                Operation:=xlNone, SkipBlanks:=True, Transpose:=False
                            Sheets("Daily").Range("BO" & CurOutRow) = Left(SheetName(Primary), 1) & "T"
                        End If
                    End If
                End If
                If .Range("M2") < 50 Then
                    If Right(Sheets("Daily").Range("BO" & CurOutRow), 1) <> "S" And Right(Sheets("Daily").Range("BO" & CurOutRow + 1), 1) <> "S" Then
                        If Sheets("Daily").Range("BG" & CurOutRow + 1) = "" Then
                            .Range("L2:O2").Copy
                            Sheets("Daily").Cells(CurOutRow + 1, .Range("BG1").Column).PasteSpecial Paste:=xlPasteValues, _
                                                Operation:=xlNone, SkipBlanks:=True, Transpose:=False
                            Sheets("Daily").Range("BO" & CurOutRow + 1) = Left(SheetName(Primary), 1) & "S"
                        End If
                        If Right(Sheets("Daily").Range("BO" & CurOutRow), 1) = "T" Then
                            .Range("G2:J2").Copy
                            Sheets("Daily").Cells(CurOutRow, Range("AW2").Column).PasteSpecial Paste:=xlPasteValues, _
                                                Operation:=xlNone, SkipBlanks:=True, Transpose:=False
                            Sheets("Daily").Range("BO" & CurOutRow) = Left(SheetName(Primary), 1) & "S"
                        End If
                    End If
                End If
            End If

Is there a way to make each section use a sub, I get confused when I have to pass ranges with sheets etc. Thanks in advance.
 

Excel Facts

Can Excel fill bagel flavors?
You can teach Excel a new custom list. Type the list in cells, File, Options, Advanced, Edit Custom Lists, Import, OK
You must log in or register to reply here.

Similar threads

T
  • Question
VBA Macro running, but not saving to Sharepoint
Replies
3
Views
262
Fluff
Fluff
excelbytes
  • Solved
Subscript Out Of Range Error 9
Replies
2
Views
190
excelbytes
excelbytes
K
  • Question
VBA Copy, Paste to Different Workbook, Save as then loop the action through slicer
Replies
1
Views
226
krisoey
K
S
  • Question
Keep getting an "Error 1004: item could not be found in the OLAP cube" when applying the filter to pivot table
Replies
5
Views
356
RoryA
RoryA
M
  • Question
Specific columns from auto filter range - VBA
Replies
6
Views
91
Peter_SSs
Peter_SSs

Forum statistics

Threads
1,203,552
Messages
6,056,056
Members
444,841
Latest member
SF_Marnie

Share this page

We've detected that you are using an adblocker.

We have a great community of people providing Excel help here, but the hosting costs are enormous. You can help keep this site running by allowing ads on MrExcel.com.
Allow Ads at MrExcel

Which adblocker are you using?

Disable AdBlock

Follow these easy steps to disable AdBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the icon in the browser’s toolbar.
2)Click on the "Pause on this site" option.
Go back

Disable AdBlock Plus

Follow these easy steps to disable AdBlock Plus

1)Click on the icon in the browser’s toolbar.
2)Click on the toggle to disable it for "mrexcel.com".
Go back

Disable uBlock Origin

Follow these easy steps to disable uBlock Origin

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back

Disable uBlock

Follow these easy steps to disable uBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back
Back
Top