MessageBox opens multiple times

[loststudent]

Hello everyone!

I have a MessageBox in my application that asks whether the user wants to add a new product to the order or not. If I press 'No', it closes. When I press 'Yes', it does what it's supposed to do, lets me add another product, and so on. The problem is that once I press no, the amount of MessageBoxes I get is the number of times I pressed 'Yes' before that. How could I solve this?

The code is:

'Show MessageBox asking user if they want to add more products to the order
Private Sub Addmoreproducts()
'Declare the msg (message) and ans (answer) variables
Dim msg, ans


Do
Unload UFAddStock
Unload UFUpdateStock
msg = "Add more products to the order?"
ans = MsgBox(msg, vbYesNo)


'If answer is Yes, then close this UserForm and open the UserForm for adding more products
If ans = vbYes Then
Unload UFAddStock
UFUpdateStock.Show

End If

'If answer is No, then close all open UserForms and return to the sheet
If ans = vbNo Then Exit Do
Unload UFAddStock
Unload UFUpdateStock


'Loop for MessageBox until answer is No
Loop Until ans = vbNo


End Sub

Thank you in advance!

 

[footoo]

If ans = vbYes Then
Unload UFAddStock
UFUpdateStock.Show

'If answer is No, then close all open UserForms and return to the sheet
ElseIf ans = vbNo Then
Unload UFAddStock
Unload UFUpdateStock
Exit Do
End If

'Loop for MessageBox until answer is No
Loop

 

[mikerickson]

This should work. There were many duplicate, unneeded UnLoadings in the OP code.

How is the sub AddMoreProducts triggered? If it is by a button on UFAddStock or UFUpdateStock, there might be recursion issues. If it is called by the user from the Macro dialog, this should work.

Private Sub AddMoreProducts()
    Dim msg As String, ans As Long
    Dim msg, ans

    msg = "Add more products to the order?"
    Do
        Unload UFAddStock
        Unload UFUpdateStock
    
        ans = MsgBox(msg, vbYesNo)


       'If answer is Yes, then close this UserForm and open the UserForm for adding more products
        If ans = vbYes Then
            UFUpdateStock.Show
        End If
    Loop Until ans = vbNo
End Sub

 

[loststudent]

Hi, thank you for the code. Unfortunately, it didn't change anything. The sub is called from another sub.

 

[loststudent]

Hi, thank you, but it didn't work

 

[mikerickson]

Do frmUpdateStock and frmAddStock invoke each other?
Does the other sub have any looping that might be where the problem lies?

What happens when you step through the code?