My code does not filter why is this

[Darren Smith]

It`s filtering on Col 11 but it just hides all the data and does not filter???

[CODE=vba]Private Sub Filter_Jobs_By_Months_Click()
Dim Database(1 To 100, 1 To 15)
Dim My_Range As Integer
Dim colum As Byte
Dim ws As Worksheet
Dim qt As QueryTable

Application.ScreenUpdating = False

Set ws = ThisWorkbook.Worksheets("TGS JOB RECORD")

For Each ws In ActiveWorkbook.Worksheets
For Each qt In ws.QueryTables
qt.Refresh
Next qt
Next ws

ws.Range("A2").AutoFilter Field:=11, Criteria2:=Me.Months.Value

Application.ScreenUpdating = True


End Sub

[/CODE]

 

[RoryA]

Why is the autofilter outside the ws loop?

If all the data is hidden, nothing matches the criterion. Why are you using criteria2 rather than Criteria1?

 

[Darren Smith]

Why is the autofilter outside the ws loop?

If all the data is hidden, nothing matches the criterion. Why are you using criteria2 rather than Criteria1? I Changed it to 1 then back to 2 but now have an issue see below

ws.Range("A2").AutoFilter Field:=11, Criteria1:=Me.Months.Value

This was working now has stopped working says run time error 91

 

[RoryA]

Again, why is that line outside the loop?

 

[Darren Smith]

How could I put it inside the loop?

 

[RoryA]

Move it above the Next ws line.

 

[Darren Smith]

Thanks all good now