need help

[chobanne]

i have 2 codes

first

Private Sub Worksheet_SelectionChange(ByVal Target As Excel.Range)
If Range("E33") = 1 Then
CommandButton3.Visible = False
CommandButton4.Visible = False
ActiveSheet.Shapes("OKVIR2").Visible = False
Else
CommandButton3.Visible = True
CommandButton4.Visible = True
ActiveSheet.Shapes("OKVIR2").Visible = True
End If
End Sub

and second

Private Sub Worksheet_SelectionChange2(ByVal Target As Excel.Range)
If Range("E34") = 1 Then
CommandButton7.Visible = False
Else
CommandButton7.Visible = True
End If
End Sub

first is working, second dont, anyone know why? where is mistake?

 

[mouse88]

I can only imagine it is because you have named the second sub routine "SelectionChange2" which will not automatically fire on the selection changed event.

You would want to do it all under the first one:

Private Sub Worksheet_SelectionChange(ByVal Target As Excel.Range)
 
If Range("E33") = 1 Then
    CommandButton3.Visible = False
    CommandButton4.Visible = False
    ActiveSheet.Shapes("OKVIR2").Visible = False
Else
    CommandButton3.Visible = True
    CommandButton4.Visible = True
    ActiveSheet.Shapes("OKVIR2").Visible = True
End If
 
If Range("E34") = 1 Then
    CommandButton7.Visible = False
Else
    CommandButton7.Visible = True
End If
 
End Sub

Try to indent your code otherwise it makes it more difficult for people to read.

 

[trunten]

You can only have one worksheet change procedure per sheet. The body of your second piece of code needs to be copied into the first bot of code.
You could Also do with checking whether or not either of those cells are changed before you bother running that ode though.

 

[chobanne]

I can only imagine it is because you have named the second sub routine "SelectionChange2" which will not automatically fire on the selection changed event.

You would want to do it all under the first one:

Private Sub Worksheet_SelectionChange(ByVal Target As Excel.Range)
 
If Range("E33") = 1 Then
    CommandButton3.Visible = False
    CommandButton4.Visible = False
    ActiveSheet.Shapes("OKVIR2").Visible = False
Else
    CommandButton3.Visible = True
    CommandButton4.Visible = True
    ActiveSheet.Shapes("OKVIR2").Visible = True
End If
 
If Range("E34") = 1 Then
    CommandButton7.Visible = False
Else
    CommandButton7.Visible = True
End If
 
End Sub

Try to indent your code otherwise it makes it more difficult for people to read.

you are right, i ll keep it on my mind in future. It works but i have little problem with command button7 again. it will disapear or appear only if i start clicking on random cell in my sheet. there is no problem with cb3 and cb4. you know how to handle with this