On Error GOTO Quit

Guzzlr

Well-known Member
Joined
Apr 20, 2009
Messages
712
Code:
On Error GoTo Quit:
Code:
Quit:
MsgBox ("Please Add Data to Template Sheet" _
& vbNewLine & "Then Run Program")

Hello All,
I have the above code. The On Error GoTo Quit is at the top of the code, with the Quit: at the bottom. The problem is my message box keeps popping up, even when no errors are happening?
What am I doing wrong?
Thanks
 

Rick Rothstein

MrExcel MVP
Joined
Apr 18, 2011
Messages
35,412
Office Version
2010
Platform
Windows
Code:
On Error GoTo Quit:
Code:
Quit:
MsgBox ("Please Add Data to Template Sheet" _
& vbNewLine & "Then Run Program")

Hello All,
I have the above code. The On Error GoTo Quit is at the top of the code, with the Quit: at the bottom. The problem is my message box keeps popping up, even when no errors are happening?
What am I doing wrong?
Thanks
You have to put End Sub or End Function (depending on what type of code procedure you have) immediately before the Quit: label to stop your code from falling through.
 

DanteAmor

Well-known Member
Joined
Dec 3, 2018
Messages
7,804
Office Version
2007
Platform
Windows
It is likely that some other error is happening and you are not viewing it.


It is not recommended to use: On Error GoTo


It is advisable to try to control each of the errors.


If you like, put all your code here to review it and adjust the code to control errors.
 

Fluff

MrExcel MVP, Moderator
Joined
Jun 12, 2014
Messages
30,300
Office Version
365
Platform
Windows
You need to exit the sub, before the Quit, like
Code:
Exit Sub
Quit:
MsgBox ("Please Add Data to Template Sheet" _
& vbNewLine & "Then Run Program")
I would also advise against using VBA keywords (like Quit) for variables, GoTos etc.
 

Guzzlr

Well-known Member
Joined
Apr 20, 2009
Messages
712
thank you all...it's working now. I got rid of the word "Quit" and used ErrHandler instead
 

Fluff

MrExcel MVP, Moderator
Joined
Jun 12, 2014
Messages
30,300
Office Version
365
Platform
Windows
You're welcome & thanks for the feedback
 

Forum statistics

Threads
1,077,957
Messages
5,337,402
Members
399,144
Latest member
Lauren Ward

Some videos you may like

This Week's Hot Topics

Top