Optimize If...Else statement

[Digitborn.com]

Hi,

Please, help me optimize (make shorter code) the following If...Else statement:

If cmbNamespace.Text <> "" Then
strFilter1 = "Namespace = '" & Trim(cmbNamespace.Text) & "'"
strFilter = strFilter1
Else
strFilter1 = ""
End If
If cmbClass.Text <> "" Then
strFilter2 = "Class = '" & Trim(cmbClass.Text) & "'"
strFilter = strFilter2
Else
strFilter2 = ""
End If
If txtType.Text <> "" Then
strFilter3 = "Type like '%" & txtType.Text & "%'"
strFilter = strFilter3
Else
strFilter3 = ""
End If

If strFilter2 = "" And strFilter3 = "" Then
strFilter = strFilter1
ElseIf strFilter2 <> "" And strFilter3 <> "" Then
strFilter = strFilter2 & " And " & strFilter3
End If
If strFilter1 = "" And strFilter3 = "" Then
strFilter = strFilter2
ElseIf strFilter1 <> "" And strFilter3 <> "" Then
strFilter = strFilter1 & " And " & strFilter3
End If
If strFilter1 = "" And strFilter2 = "" Then
strFilter = strFilter3
ElseIf strFilter1 <> "" And strFilter2 <> "" Then
strFilter = strFilter1 & " And " & strFilter2
End If

If strFilter1 = "" And strFilter2 = "" And strFilter3 = "" Then
strFilter = ""
ElseIf strFilter1 <> "" And strFilter2 <> "" And strFilter3 <> "" Then
strFilter = strFilter1 & " And " & strFilter2 & " And " & strFilter3
End If

You can pass me any variants of statements, loops, number of variables from VB6 or VB.NET.

 

[Sandeep Warrier]

How about...

Sub Test()
    Dim WFN As WorksheetFunction
    Set WFN = Application.WorksheetFunction
    strFilter1 = "Namespace = '" & Trim(cmbNamespace.Text) & "'"
    strFilter2 = "Class = '" & Trim(cmbClass.Text) & "'"
    strFilter3 = "Type like '%" & txtType.Text & "%'"
    strFilter = strFilter1 & " And " & strFilter2 & " And " & strFilter3
    If cmbNamespace.Text = "" Then
        strFilter = Trim(WFN.Substitute(strFilter, strFilter1 & " And ", ""))
    End If
    If cmbClass.Text = "" Then
        strFilter = Trim(WFN.Substitute(strFilter, " And " & strFilter2, ""))
    End If
    If txtType.Text = "" Then
        strFilter = Trim(WFN.Substitute(strFilter, " And " & strFilter3, ""))
    End If
End Sub

<input id="gwProxy" type="hidden"><!--Session data--><input *******="jsCall();" id="jsProxy" type="hidden">

 

[Digitborn.com]

Thanks very much, it's working, it's simple, it's useful

 

[Sandeep Warrier]

Thanks very much, it's working, it's simple, it's useful

You're welcome
<input id="gwProxy" type="hidden"><!--Session data--><input *******="jsCall();" id="jsProxy" type="hidden">