Please can you advise on my code

[ipbr21054]

Hi,

Code in use as supplide.

I complete the userform but when i press the command button to send the values to the worksheet i now see End If Without Block If.

Private Sub CommandButton1_Click()
    Dim i As Integer
    Dim X As Long
    Dim ControlsArr(1 To 8) As Variant
    
    
    For i = 1 To 8
        If i > 2 Then
            With Me.Controls("ComboBox" & i)
                If .ListIndex = -1 Then
                    MsgBox "YOU MUST COMPLETE ALL FIELDS", vbCritical, "MC LIST TRANSFER"
                    TextBox1.SetFocus
                    Exit Sub
                Else
                    ControlsArr(i) = .Value
                End If
            End With
        Else
            ControlsArr(i) = Me.Controls("TextBox" & i).Value
        End If
    Next i
        
        Application.ScreenUpdating = False
        
        With ThisWorkbook.Worksheets("MC LIST")
            .Range("A8").EntireRow.Insert Shift:=xlDown
            .Range("A8:I8").Borders.Weight = xlThin
            .Cells(8, 1).Resize(, UBound(ControlsArr)).Value = ControlsArr
            

        End With
        Range("B8").Select
        Range("A8").Select
        ActiveWorkbook.Save

        Application.ScreenUpdating = True
        MsgBox "Database Has Been Updated", vbInformation, "SUCCESSFUL MESSAGE"
       With ThisWorkbook.Worksheets("MC LIST")
       If .AutoFilterMode Then .AutoFilterMode = False
            X = .Cells(.Rows.Count, 1).End(xlUp).Row
            .Range("A7:I" & X).Sort Key1:=Range("A8"), Order1:=xlAscending, Header:=xlGuess
            .Range("A8").Select
        End With
        End If
        Unload McListForm
End Sub

 

[MARK858]

There isn't an If to go with the End If in red below.

    Application.ScreenUpdating = True
    MsgBox "Database Has Been Updated", vbInformation, "SUCCESSFUL MESSAGE"
    With ThisWorkbook.Worksheets("MC LIST")
        If .AutoFilterMode Then .AutoFilterMode = False
        X = .Cells(.Rows.Count, 1).End(xlUp).Row
        .Range("A7:I" & X).Sort Key1:=Range("A8"), Order1:=xlAscending, Header:=xlGuess
        .Range("A8").Select
    End With
End If
Unload McListForm
End Sub

 

[ipbr21054]

Isnt this it ?

If .AutoFilterMode Then .AutoFilterMode = False

 

[dma431]

The End If should go above End With.
in your case you don't need End If

 

[ipbr21054]

The End If should go above End With.
in your case you don't need End If

That gives me the same message

 

[MARK858]

Isnt this it ?

If .AutoFilterMode Then .AutoFilterMode = False

No, the If statement there has a start and finish (the .AutoFilterMode = False finishes it ).
The End If needs deleting.

 

[ipbr21054]

@MARK858 you are correct thanks.
Deleted and all ok .