Probably a really easy question...

[largeselection]

Quick question, I want to reference a workbook that i mentioned quite a bit in my macro code. However, I want to be able to change this workbook by just changing one line of code rather than having to go into my rather long code to change it every time.

Here's what I have so far:

Dim MyFile As Workbook

Set MyFile = ActiveWorkbook

Dim MyTarget As Workbook

Set MyTarget = windows("week 28 O.xls")

Then later in the code I have it reference MyTarget and MyFile.

MyFile opens the current workbook that I am creating and I was hoping that I could put MyTarget.Activate into every instance where it occurs and it would reference week 28 o.xls. (originally when I recorded this it had "week 28 O.xls".activate) So what I figured is that rather than having to go in and change the 28 to a 29 in every instance in the code (about 25 of them) I would just set MyTarget = ___ that way if I want to change to week 29 in all those instances I just have to change the 28 to a 29 in the set MyTarget line and then all the references to my target would apply to the new week 29.

However I'm getting an error at the Set MyTarget = windows("week 28 O.xls") line.

I feel like this is probably an easy fix. Please ask any and all questions so I can help clarify.

 

[pgc01]

Hi

There is an inconsistency here:

Dim MyTarget As Workbook

Set MyTarget = windows("week 28 O.xls")

You declare MyTarget as a workbook and then try to assign it a window??

Please try:

Dim MyTarget As Workbook

Set MyTarget = Workbooks("week 28 O.xls")

 

[largeselection]

I put this in at the beginning of my code

Dim MyFile As Workbook

Set MyFile = ActiveWorkbook

Dim MyTarget As Workbook
Set MyTarget = Workbook("Week 28 0.xls")

and it came up with an error at the same set my target = workbook line. I also tried replacing Week 28 O.xls with the file path and that did not work either.

Thanks for your suggestion!

 

[pgc01]

Hi Again

Did you forget the s in the Workbooks Collection or was it just a typo in the post?

Set MyTarget = Workbooks("Week 28 0.xls")

 

[Norie]

Is the workbook actually open?

 

[largeselection]

Sorry about that, it was a typo. Here is a snipit of the code

Dim MyFile As Workbook
Set MyFile = ActiveWorkbook

Dim MyTarget As Workbook
Set MyTarget = Workbooks("Week 28 O.xls")

MyTarget.Activate
Range("D190").Select
ActiveWindow.SmallScroll Down:=-30
Range("A160:E160").Select
Range(Selection, Selection.End(xlDown)).Select
Selection.Copy
MyFile.Activate
ActiveSheet.Paste
Sheets("547").Select
MyTarget.Activate
Sheets("547").Select
Range("E208").Select
ActiveWindow.SmallScroll Down:=-27
Range("A160:E160").Select
Range(Selection, Selection.End(xlDown)).Select
Application.CutCopyMode = False
Selection.Copy
MyFile.Activate
Range("A3").Select
ActiveSheet.Paste

and it continues on in this way basically copying information from one workbook and pasting into the correct place in another workbook.

Thanks for all your help

 

[largeselection]

Yes the workbook is open.

 

[pgc01]

I'm sorry but I cannot reproduce your error. The only other thing that comes to my mind is that the workbook name is misspelled, like the digit "0" for the letter "O" or characters that are not visible and you think they are spaces.

Do this simple test.

Sub Test()
Dim lWbk As Long
 
For lWbk = 1 To Workbooks.Count
   MsgBox Workbooks(lWbk).Name & ", Ind:" & lWbk
Next lWbk
End Sub

And see if the "Week 28 O.xls" workbook appears in the list of opened workbooks and under which index.

 

[largeselection]

It popped up and said

Week 28 O.xls, Ind:2

and when I just tried to run the macro again I got this error:

Compile error:

Sub or Function not defined.

 

[pgc01]

Ok. I did not understand the part :"and when I just tried to run the macro again I got this error: ...", what macro?

Anyway, please run this, to check the name of the workbook:

Sub NameCodes()
Dim sWbk As String, sCodes As String
Dim l As Long
 
sWbk = Workbooks(2).Name
sCodes = sWbk
 
For l = 1 To Len(sWbk)
    sCodes = sCodes & vbCrLf & Mid(sWbk, l, 1) & " : " & AscW(Mid(sWbk, l, 1))
Next l
MsgBox sCodes
End Sub

This is what should be the output on the message box:

Week 28 O.xls
W : 87
e : 101
e : 101
k : 107
  : 32
2 : 50
8 : 56
  : 32
O : 79
. : 46
x : 120
l : 108
s : 115