Problems on passing values between modules.

[HerrSober]

I am building a more complex report and since there are lots of repetive subs I want to structure them into different modules. However I experience empty values for some weird reason. (My question is more detailed written in "Module 3")

In this example I could have solved it by setting Public const x = 2.
But... since both the X and Y value is going to be calculated I find no other solution than to put them on subroutines and calculate it from there.

I am using Microsoft Excel 2010.

'In Module 3
Sub ExcecutionSub()
ValueSub1
ValueSub2

Debug.Print "The X value goes fine; " & x
Debug.Print [B]"X and Y go together in debug.print:[/B] "; x & y

[B]'''But look when I try it in a msgbox. Only X is visible[/B]

MsgBox x, q

End Sub

'in Module1
Public y As Long
 
Sub ValueSub1()
y = 2
End Sub

 'in Module2
Public x As Long

Sub ValueSub2()
    x = 8
End Sub

I hope you can help me out!

 

[Danerida]

'In Module 3
Sub ExcecutionSub()
ValueSub1
ValueSub2

Debug.Print "The X value goes fine; " & x
Debug.Print [B]"X and Y go together in debug.print:[/B] "; x & y

[B]'''But look when I try it in a msgbox. Only X is visible[/B]

MsgBox x, [B][COLOR=#ff0000]q[/COLOR][/B]

End Sub

The red q should be y shouldn't it?

 

[mikerickson]

You aren't using Option Explict.

MsgBox x, q

That line is passing two arguments to MsgBox 1) prompt:= x and 2) Button:= q (=0), which is the value of vbOKOnly.
If you want to see the two values

MsgBox x & ":" & y

Using Option Explicit would have alerted you to the presence of the undeclared typo q

 

[HerrSober]

The red q should be y shouldn't it?

You're right! A "typing error". Thanks for noticing.

You aren't using Option Explict.

MsgBox x, q

That line is passing two arguments to MsgBox 1) prompt:= x and 2) Button:= q (=0), which is the value of vbOKOnly.
If you want to see the two values

MsgBox x & ":" & y

Using Option Explicit would have alerted you to the presence of the undeclared typo q

Thanks! It solved my problem