Public variables

[confusion123]

In general, is it preferable to pass variables instead of declaring a variable public (so that its value can be used in separate modules)?

If not, what's the alternative to declaring variables publically?

I've experimented with using classes but it seems an overkill (and even then I have to declare it public once), eg:

In a module, I have:

Global MyCol As ClsVariables

This is ClsVariables:

Public Property Get Col() As Integer
    Col = pCol
End Property
Public Property Let Col(ByVal Co As Integer)
    pCol = Co
End Property

 

[adam087]

I suspect the most robust way is passing variables through, but for Excel's fairly 'lite' environment I'm happy just creating a separate module (not class) for variables and declaring them all in there, and using them as you see fit. Not saying that's the best, or 'correct' way, but it works for me.

/AJ

 

[RoryA]

It is generally better to limit the scope of variables to as narrow as possible, so passing variables between procedures is usually preferable. It is rarely necessary to have a Public variable but it can occasionally be simplest.

 

[confusion123]

It is generally better to limit the scope of variables to as narrow as possible, so passing variables between procedures is usually preferable. It is rarely necessary to have a Public variable but it can occasionally be simplest.

I've just converted one of my programs from using classes to passing variables and it works (and is easier to understand).

Can you think of an example where you HAVE (not just because it's easier) to declare a variable as public?

 

[RoryA]

Not offhand, no. I think there's probably always a way to avoid it. Having said that, I imagine there could be situations where a Public variable would be less confusing than the alternative; much like Goto - avoid as a rule, but be prepared to break the rule as long as you have a good reason, and know what you're doing.

 

[confusion123]

Thanks