Question about - On Error GoTo

[Guinaba]

Hi guys,

Not sure where what I am missing here, I am trying to use On Error GoTo to show a msg: The File is closed, please open it before running the macro, However, even when the file is opened the macro keep showing the error. I am adding the Erro GoTo righ before the error line. Is that correct?

On Error GoTo Label:
Set CurrWkWB = Workbooks("WTD Sales VS Demand Tracker_W" & CurrWk & "_" & WeekdayName(Weekday(Date), True, vbSunday) & ".XLSM")
CurrWkWB.Activate

Label:
MsgBox ("Keep both files (Current and Next Week) opened before running the Macro"), vbExclamation
Exit Sub

 

[Rick Rothstein]

I assume when you say "keep showing the error" you mean your MessageBox. The problem is you have the "Exit Sub" statement in the wrong location... it needs to be placed before the MessageBox statement, not after it, otherwise even properly running code will move down to the MessageBox statement... the "Exit Sub" stops that from happening.