remove sheets and copy content

vics_roo

Board Regular
Joined
Apr 3, 2015
Messages
75
Hello

I need to process some files like that.
Need to create new sheet for each file.
Open file and copy content to new created sheet.
Previous sheets must be delete.

1. For delete sheets (all except 1) I using loop with Worksheets(i).Delete. But appearing message "This sheet hold data. Do you want to delete sheet?" How delete sheets quite ?

2. Copy content file to new sheet not working.
The error is
Run-time error '438':
Object doesn't support this property of method


Here is code with comments

VBA Code:
Private Sub main()

    Application.ScreenUpdating = False
   
    'get list of files
    Dim dirName As String
    dirName = getDirName()
    Dim fileNameList As Collection
    Set fileNameList = getFileNames(dirName, "dbf")
    Dim N As Long
    N = fileNameList.Count

    'vars
    Dim lastRow As Long
    Dim lastColumn As Long
    Dim lastColumnName As String
    Dim i As Long
    Dim tmpFileName As String
    Dim tmpWB As Workbook
    Dim wb As Workbook
    Dim newWS As Worksheet
    Set wb = ActiveWorkbook
    
''''''''''''''''''''''This for question one'''''''''''''''''''
    'remove old sheets except the first
    Worksheets(1).Activate
    For i = Worksheets.Count To 2 Step -1
        Worksheets(i).Delete
    Next i
''''''''''''''''''''''End for question one'''''''''''''''''''
    


    'loop for files
    For i = 1 To N
        Application.StatusBar = "Processing " & fileNameList.Item(i)
        tmpFileName = dirName & "\" & fileNameList.Item(i)

        Workbooks.Open tmpFileName, UpdateLinks:=0
        Set tmpWB = ActiveWorkbook
        
        lastRow = getLastRow()
        lastColumn = getLastColumn()
        lastColumnName = getColumnName(lastColumn)
        
        'create sheet and set name as filename
        Set newWS = wb.Worksheets.Add(After:=Worksheets(Worksheets.Count))
        newWS.Name = fileNameList.Item(i)
        tmpWB.Activate
        ''''''''''''''''''''''This for question two'''''''''''''''''''
        tmpWB.ActiveSheet.Range("A2:" & lastColumnName & lastRow).Copy wb.newWS.Range("A" & 3)   'Here is error
        ''''''''''''''''''''''End for question two'''''''''''''''''''
        
        'close file without saving
        ActiveWorkbook.Close savechanges:=False
    Next
  
    'unfreeze
    Application.ScreenUpdating = False
    MsgBox " Files processed"
    Shell """" & "explorer.exe" & """ """ & dirName & """", vbMaximizedFocus
End Sub

Thanks at advance
 

Excel Facts

Remove leading & trailing spaces
Save as CSV to remove all leading and trailing spaces. It is faster than using TRIM().
Hi
Try
VBA Code:
''''''''''''''''''''''This for question one'''''''''''''''''''
    'remove old sheets except the first
    Worksheets(1).Activate
    Application.DisplayAlerts = False '<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
    For i = Worksheets.Count To 2 Step -1
        Worksheets(i).Delete
    Next i
     Application.DisplayAlerts = False '<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
''''''''''''''''''''''End for question one'''''''''''''''''''


VBA Code:
 ''''''''''''''''''''''This for question two'''''''''''''''''''
        tmpWB.ActiveSheet.Cells(llastColumnName, lastRow).Copy wb.newWS.Range("A" & 3)  'Range("A2:" & lastColumnName & lastRow).Copy wb.newWS.Range("A" & 3)   'Here is error
        ''''''''''''''''''''''End for question two'''''''''''''''''''
 
Upvote 0

Forum statistics

Threads
1,214,839
Messages
6,121,892
Members
449,058
Latest member
Guy Boot

We've detected that you are using an adblocker.

We have a great community of people providing Excel help here, but the hosting costs are enormous. You can help keep this site running by allowing ads on MrExcel.com.
Allow Ads at MrExcel

Which adblocker are you using?

Disable AdBlock

Follow these easy steps to disable AdBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the icon in the browser’s toolbar.
2)Click on the "Pause on this site" option.
Go back

Disable AdBlock Plus

Follow these easy steps to disable AdBlock Plus

1)Click on the icon in the browser’s toolbar.
2)Click on the toggle to disable it for "mrexcel.com".
Go back

Disable uBlock Origin

Follow these easy steps to disable uBlock Origin

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back

Disable uBlock

Follow these easy steps to disable uBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back
Back
Top