Run-time error 1004 - save as pdf problem

[vvujke]

Hi guys,

I have a problem when I run this script. don't know what the problem. Debugger gives me Run-time error 1004 and when I stop debugger excel crashes.

Private Sub Workbook_BeforeSave(ByVal SaveAsUI As Boolean, Cancel As Boolean)Dim ActSheet As Worksheet
    Dim ActBook As Workbook
    Dim CurrentFile As String
    Dim NewFileType As String
    Dim NewFile As String
    Dim pdfName As String
    Dim i As Integer, j As Integer
    If SaveAsUI Then Cancel = True
    Application.ScreenUpdating = False    ' Prevents screen refreshing.
    Application.DisplayAlerts = False
    
    CurrentFile = ThisWorkbook.FullName
 
    NewFileType = "Excel Files 2007 (*.xlsx), *.xlsx," & _
                  "Excel Files 1997-2003 (*.xls), *.xls," & _
                  "All files (*.*), *.*"
 
    NewFile = Application.GetSaveAsFilename( _
        InitialFileName:=ThisWorkbook.Path & "\" & ActiveSheet.Range("F6") & " Invoice " & ActiveSheet.Range("B11"), _
        fileFilter:=NewFileType)
    
  
 If NewFile <> "" And NewFile <> "False" Then
        ActiveWorkbook.SaveAs Filename:=NewFile, _
            FileFormat:=xlNormal, _
            Password:="", _
            WriteResPassword:="", _
            ReadOnlyRecommended:=False, _
            CreateBackup:=False
 
 pdfName = ThisWorkbook.Path & "\PDF Archive\" & ActiveSheet.Range("F6") & " Invoice " & ActiveSheet.Range("B11")
If Dir(pdfName & ".pdf") <> "" Then
    If Dir(pdfName & " copy.pdf") <> "" Then
        i = 1
        j = 1
        Do While i = 1
         If Dir(pdfName & " copy (" & CStr(j) & ").pdf") <> "" Then
              j = j + 1
              i = 1
             Else
              i = 2
         End If
         Loop
        ActiveSheet.ExportAsFixedFormat Type:=xlTypePDF, Filename:= _
        pdfName & " copy (" & CStr(j) & ").pdf", _
          Quality:=xlQualityStandard, IncludeDocProperties:=True, _
          IgnorePrintAreas:=False, _
          OpenAfterPublish:=False
     End If
         ActiveSheet.ExportAsFixedFormat Type:=xlTypePDF, Filename:= _
        pdfName & " copy" & ".pdf", _
          Quality:=xlQualityStandard, IncludeDocProperties:=True, _
          IgnorePrintAreas:=False, _
          OpenAfterPublish:=False
End If
     ActiveSheet.ExportAsFixedFormat Type:=xlTypePDF, Filename:= _
        pdfName & ".pdf", _
          Quality:=xlQualityStandard, IncludeDocProperties:=True, _
          IgnorePrintAreas:=False, _
          OpenAfterPublish:=False
        
        Set ActBook = ActiveWorkbook
        Workbooks.Open CurrentFile
        ActBook.Close
    End If
    Application.DisplayAlerts = False
End Sub

Highlighted code is

<code style="margin: 0px; padding: 0px; font-style: inherit;"></code>    [COLOR=#daa520] ActiveSheet.ExportAsFixedFormat Type:=xlTypePDF, FileName:= _
[/COLOR][COLOR=#daa520]        pdfName & ".pdf", _[/COLOR]
[COLOR=#daa520]          Quality:=xlQualityStandard, IncludeDocProperties:=True, _[/COLOR]
[COLOR=#daa520]          IgnorePrintAreas:=False, _[/COLOR]
       ->  [COLOR=#daa520]OpenAfterPublish:=False[/COLOR]

It manages to save pdf version of the file, but then excel show's popup with Run-time error 1004, with debug and end options. When I chose debug code is highlighted and if I chose end, Excel crashes.

Can you help, please? truly don't know what the problem tnx

P.S. It was working 'till some time ago and I haven't change anything in the code

 

[wigi]

Did you use:

Debug.Print pdfName & ".pdf"

to see what is in there at the moment of generating the PDF?
Don't you delete the PDF file in case it would already exist in the directory?