Run time error 91 - explanation requred

[auntie bella]

I am getting a Run time error 91 on the code below - (Object variable or With Block variable not set).

Unfortunately as a novice at VBA I haven't a clue what this is about .
However the code does do what I want it to.
Can someone explain for me?

==========================================

Sub CommentAddOrEdit()
Dim rFind As Range

For Each c In Range("C1:D12")
If Not c.Comment Is Nothing Then c.Comment.Delete
Set rFind = Worksheets("Sheet2").Rows(1).Find(What:=c.Value, LookAt:=xlWhole)
If Not rFind.Comment Is Nothing Then
c.AddComment.Text rFind.Comment.Text
End If
Next c
End Sub

 

[RoryA]

That implies that the value you searched for wasn't found. You need to test for that:

Sub CommentAddOrEdit()
Dim rFind As Range

For Each c In Range("C1:D12")
If Not c.Comment Is Nothing Then c.Comment.Delete
Set rFind = Worksheets("Sheet2").Rows(1).Find(What:=c.Value, LookAt:=xlWhole)
If not rFind is Nothing then
   If Not rFind.Comment Is Nothing Then
       c.AddComment.Text rFind.Comment.Text
   End If
Else
   msgbox c.Value " was not found"
End If
Next c
End Sub

 

[GlennUK]

And what if c.Value isn't found? Wouldn't rFind be nothing? So maybe you should test for that?

Edit:Rory has coded it ... although he says rFound instead of rFind.

 

[Sektor]

[COLOR="Blue"]Sub[/COLOR] CommentAddOrEdit()

    [COLOR="Blue"]Dim[/COLOR] rFind [COLOR="Blue"]As[/COLOR] Range, c [COLOR="Blue"]As[/COLOR] Range

    [COLOR="Blue"]For[/COLOR] [COLOR="Blue"]Each[/COLOR] c [COLOR="Blue"]In[/COLOR] Range("C1:D12")
    
        [COLOR="Blue"]If[/COLOR] [COLOR="Blue"]Not[/COLOR] c.Comment [COLOR="Blue"]Is[/COLOR] [COLOR="Blue"]Nothing[/COLOR] [COLOR="Blue"]Then[/COLOR] c.Comment.Delete
    
        [COLOR="Blue"]Set[/COLOR] rFind = Worksheets("Sheet2").Rows(1).Find(What:=c.Value, LookAt:=xlWhole)
    
        [COLOR="Blue"]If[/COLOR] [COLOR="Blue"]Not[/COLOR] rFind [COLOR="Blue"]Is[/COLOR] [COLOR="Blue"]Nothing[/COLOR] [COLOR="Blue"]Then[/COLOR]
    
            [COLOR="Blue"]If[/COLOR] [COLOR="Blue"]Not[/COLOR] rFind.Comment [COLOR="Blue"]Is[/COLOR] [COLOR="Blue"]Nothing[/COLOR] [COLOR="Blue"]Then[/COLOR]
                c.AddComment.Text rFind.Comment.Text
            [COLOR="Blue"]End[/COLOR] [COLOR="Blue"]If[/COLOR]
        
        [COLOR="Blue"]End[/COLOR] [COLOR="Blue"]If[/COLOR]
    [COLOR="Blue"]Next[/COLOR] c
    
[COLOR="Blue"]End[/COLOR] [COLOR="Blue"]Sub[/COLOR]

 

[auntie bella]

many thanks for quick replies..... (i'm another step closer!)

 

[RoryA]

although he says rFound instead of rFind.

No, he doesn't (now).

 

[GlennUK]

No, he doesn't (now).

aha, you spotted it!!!!