Runtime error for savefile

[mysticmario]

There's this one line of code that throws runtime error at me

        wbNew.SaveAs Filename:=wbaddress & "/" & wbname2 & ".xlsm", _
            FileFormat:=xlOpenXMLWorkbookMacroEnabled, CreateBackup:=False

, but the best thing is I used to run this line of code without a problem when i had premade buttons on the sheet. Now when my buttons are being created "on the fly" when new sheet is being created it suddenly stopped running, can anyone help me figure out what happened?

 

[6StringJazzer]

Please paste all of the code from this sub into a post (not a picture). Very often a problem originates somewhere besides the line raising the error.

What are the values of wbaddress and wbname2 at the point the error occurs? Usually a SaveAs runtime error is caused by an invalid path or filename. This may have nothing at all to do with your buttons.

 

[mysticmario]

Ye shoudl've done that in the first place. here you go

Sub ZapiszWchmurze_Click()
    Dim wbname As String, wbaddress As String
    Dim wbOrig As Workbook, wbNew As Workbook
    Dim shtNames As Variant, sName As Variant
    Application.ScreenUpdating = False
    Set wbOrig = ThisWorkbook
    wbname2 = InputBox("Podaj nazwę", "Nazwa pliku")
    wbname = ActiveSheet.Name
    wbaddress = wbOrig.Worksheets("PANEL WYCEN").Range("H17").Value
    shtNames = Array("MAG", "SZABLON_SZAFA", "KARTA REALIZACJI", "OFERTA", wbname)
  
    Set wbNew = Workbooks.Add(xlWBATWorksheet)  'Create new wb with a single blank sheet
  
    For Each sName In shtNames
        wbOrig.Worksheets(sName).Copy After:=wbNew.Worksheets(wbNew.Sheets.Count)
    Next sName
  
    Application.DisplayAlerts = False
        wbNew.Worksheets(1).Delete
        'wbOrig.Worksheets(wbname).Delete
      
        wbNew.SaveAs Filename:=wbaddress & "/" & wbname2 & ".xlsm", _
            FileFormat:=xlOpenXMLWorkbookMacroEnabled, CreateBackup:=False
        'wbNew.Close savechanges:=False             '<--- Uncomment this if you want to close the new workbook
        wbNew.Worksheets("MAG").Visible = xlSheetVeryHidden
        wbNew.Worksheets("KARTA REALIZACJI").Visible = xlSheetVeryHidden
        wbNew.Worksheets("SZABLON_SZAFA").Visible = xlSheetVeryHidden
        ActiveSheet.Buttons(sheetName & "_" & "Button 3").Visible = True

       
        'wbNew.Close savechanges:=False             '<--- Uncomment this if you want to close the new workbook
      
    Application.DisplayAlerts = False
    Application.ScreenUpdating = False
  
End Sub

and also for refference value/path provided in Sheets("PANEL WYCEN").Range("H17") - wbadress = C:\Users\artpr\OneDrive - ART-PRO Sp. z o.o\Dokumenty\Wyceny

 

[RoryA]

Why are you using a forward slash?

 

[mysticmario]

Why are you using a forward slash?

This is the way path is created using this routine, placed onto "Browse" button

Sub browse_Click()

Dim SharedFolder As FileDialog
Set SharedFolder = Application.FileDialog(msoFileDialogFolderPicker)
With SharedFolder
    .Title = "Wybierz folder zapisu"
    If .show <> -1 Then GoTo NoSel
    Sheets("PANEL WYCEN").Range("H17").Value = .SelectedItems(1)
NoSel:
End With
End Sub

 

[RoryA]

No, you put it in there:

wbaddress & "/" & wbname2

 

[mysticmario]

I think i got lost in all the problems today regarding my excel file. I thougth you were reffering to my edit that provided pth as reference to mentione drange H17.
Truth be told I have no idea why I did that - made a quick fix just now. Nevertehless the issue continues regardless.

 

[6StringJazzer]

Also need the value of wbname2.

 

[mysticmario]

Also need the value of wbname2.

Hey I'm back at this task - what do you mean by value of wbname2
Input box passes value to wbname2
What I didn't have was Dim wbname2 As String , but that didnt eliminate the error.

 

[6StringJazzer]

        wbNew.SaveAs Filename:=wbaddress & "/" & wbname2 & ".xlsm", _
            FileFormat:=xlOpenXMLWorkbookMacroEnabled, CreateBackup:=False

What is the value of wbname2 just before this line of code is executed? You will get a runtime error if the value of wbname2 is not a valid Windows file name.