save as macro help

[Phil_Pearce]

I have written the below code to save as all open workbooks apart from the workbook which contains the macro. It will save all the files including the macro workbook. What am i doing wrong?

Sub save_All()
    Dim wbk As Workbook
 
    Application.ScreenUpdating = False
 
    For Each wbk In Workbooks
        If wbk.Name <> "macro.XLS" Then
            Debug.Print wbk.Name
 
               With wbk
                .SaveAs Filename:="N:\Invest\Shared\test\transfer " & wbk.Name & ".csv"
                End With
        End If
    Next wbk
 
    Application.ScreenUpdating = True
 
End Sub

 

[Weaver]

Could be a case issue

try:

If lcase(wbk.Name) <> "macro.xls" Then

 

[Yard]

Your macro workbook is definitely called macro.xls?

In any case I would consider using

If wbk.Name <> ThisWorkbook.Name Then

also, don't you need to have

.SaveAs Filename:="N:\Invest\Shared\test\transfer " & wbk.Name & ".csv",  FileFormat:=xlCSV

And I guess you'll get an odd file name, since wbk.Name will include the existing file extension, so it'll be called "transfer Book1.xls.csv"

Maybe

Left(wbk.Name,=Iinstr(1,wbk.Name,".")-1)

would get around that one?

 

[Phil_Pearce]

Got it working now. Thanks for the info