Save As not working for me

[jcg31]

I have an application that requires two workbooks to be open.
Workbook one is named "Data"
It is used to generate two spreadsheets that are then copied to a new workbook that vba creates I then want to save that workbook as SalesData_08272011. That workbook is then mailed to a number of folk (that part is working fine)
It is the save as that I am having trouble with

dateid is the variable for the date string at end of file

The following code doesn't halt the program it crashes excel - - no idea why

wName = Workbooks.Item(2).Name
Workbooks(wName).SaveAs Filename:="C:\Sales\PaywallActivity" & "_" & dateid & ".xls"

Any help would be appreciated.
Jim

 

[jbeaucaire]

What is the code that creates the data in dateID? You need to be very careful in constructing date strings so they do not include illegal characters.

Dim DateID as String

DateID = "SalesData_" & Format(Date, "MMDDYYYY") & ".xls"

Also, is the PaywallActivity meant to be part of the filename, or it a folder? If folder, you are missing the final \ in that string.

Workbooks(wName).SaveAs Filename:="C:\Sales\PaywallActivity\" & "_" & DateID

 

[jcg31]

datehldr=Sheet1.ComboBox1.text
sepr = Split(datehldr, "/")
dateid = sepr(0) & sepr(1) & sepr(2)

Sorry my earlier post was in error the line below should have been the code offered and the only one causing the issue (C:\Sales\ is the only folder)

Workbooks(wName).SaveAs Filename:="C:\Sales\SalesData_" & DateID & "*.xls"

What is the code that creates the data in dateID? You need to be very careful in constructing date strings so they do not include illegal characters.

Dim DateID as String

DateID = "SalesData_" & Format(Date, "MMDDYYYY") & ".xls"

Also, is the PaywallActivity meant to be part of the filename, or it a folder? If folder, you are missing the final \ in that string.

Workbooks(wName).SaveAs Filename:="C:\Sales\PaywallActivity\" & "_" & DateID