Select Case Problems

ouadad

Board Regular
Joined
Jun 19, 2005
Messages
213
I thought this was an easy code to write, but apparently I'm wrong in a number of places. On one worksheet (Labelling) I'm reading a string and if it matched the case it outputs a colour in exactly the same cell pointer on another worksheet (Colour Chart).


Sub ColourChart1()
Dim irow As Integer, icol As Integer, System As String
For irow = 10 To 148
For icol = 2 To 255
System = Worksheets("Labelling").Cells(irow, icol)
Select Case System
Case "E" Or "e"
Worksheets("Colour Chart").Cells(irow, icol).Color = RGB(255, 0, 0)
Case "S" Or s
Worksheets("Colour Chart").Cells(irow, icol).Color = RGB(204, 255, 204)
Case "H" Or "h"
Worksheets("Colour Chart").Cells(irow, icol).Color = RGB(51, 153, 102)
Case "R" Or "r"
Worksheets("Colour Chart").Cells(irow, icol).Color = RGB(255, 204, 153)
Case "F" Or "f"
Worksheets("Colour Chart").Cells(irow, icol).Color = RGB(255, 255, 0)
Case "C" Or "c"
Worksheets("Colour Chart").Cells(irow, icol).Color = RGB(255, 153, 0)
Case "D" Or "d"
Worksheets("Colour Chart").Cells(irow, icol).Color = RGB(255, 0, 255)
Case Else
End Select
Next icol
Next irow

End Sub
 

Some videos you may like

Excel Facts

Repeat Last Command
Pressing F4 adds dollar signs when editing a formula. When not editing, F4 repeats last command.

VoG

Legend
Joined
Jun 19, 2002
Messages
63,650
Try

Code:
Sub ColourChart1()
Dim irow As Integer, icol As Integer, System As String
For irow = 10 To 148
    For icol = 2 To 255
        System = Worksheets("Labelling").Cells(irow, icol)
        Select Case UCase(System)
        Case "E"
            Worksheets("Colour Chart").Cells(irow, icol).Color = RGB(255, 0, 0)
        Case "S"
            Worksheets("Colour Chart").Cells(irow, icol).Color = RGB(204, 255, 204)
        Case "H"
            Worksheets("Colour Chart").Cells(irow, icol).Color = RGB(51, 153, 102)
        Case "R"
            Worksheets("Colour Chart").Cells(irow, icol).Color = RGB(255, 204, 153)
        Case "F"
            Worksheets("Colour Chart").Cells(irow, icol).Color = RGB(255, 255, 0)
        Case "C"
            Worksheets("Colour Chart").Cells(irow, icol).Color = RGB(255, 153, 0)
        Case "D"
            Worksheets("Colour Chart").Cells(irow, icol).Color = RGB(255, 0, 255)
        End Select
    Next icol
Next irow
End Sub
 

ouadad

Board Regular
Joined
Jun 19, 2005
Messages
213
Thanks, that fixed that part. Could you also tell me what's wrong with the case action statements?
 

ouadad

Board Regular
Joined
Jun 19, 2005
Messages
213
Actually, never mind. I just needed to place interior before .color.

Thanks for the help.
 

Subscribe on YouTube

Watch MrExcel Video

Forum statistics

Threads
1,106,708
Messages
5,512,962
Members
408,928
Latest member
Black Vinyl

This Week's Hot Topics

  • Sort code advice please
    Hi, I have the code below which im trying to edit but getting a little stuck. This was the original code which worked fine,columns A-F would sort...
  • SUMPRODUCT with nested If statement
    Hi everyone, Hope you're all well. I'm hoping someone will be able to point me in the right direction with a problem I'm having with a SUMPRODUCT...
  • VBA - simple sort is killing me!
    Hello all! This should be so easy, but not for me, apparently! I have a table of data that can be of varying lengths and widths. My current macro...
  • Compare Two Lists
    I have two Lists and I need to be able to Identify differences between them. List 100 comes from a workbook - the other is downloaded form the...
  • Formula that deducts points for each code I input.
    I am trying to create a formula that will have each student in my class start at 100 points and then for each code that I enter (PP for Poor...
  • Conditional formatting formula required for day of week and a value
    Hi, I have a really simple spreadsheet where column A is the date, column B is the activity total shown as a number and column C states the day of...
Top