Select multiple files to open, then later open them

[RockandGrohl]

Hi all, I have this code within a userform called CPanel.

You press a button and navigate to one of a few folders that contain reports in. You can select one or multiple files. Upon selection, the filenames for the reports are written in a text-box with a carriage return in between them, to allow the user to review the files chosen, see below.

Dim fd As FileDialog
Dim oFD As Variant
Dim fileName As String

    Set fd = Application.FileDialog(msoFileDialogFilePicker)
    With fd
        .ButtonName = "Select"
        .AllowMultiSelect = True
        .InitialFileName = "\\chw-dc03\company\Sales"
        .Filters.Add "Excel Files", "*.xls*", 1
        .Title = "Please choose a DM Report to open"
        .InitialView = msoFileDialogViewDetails
        .Show
        
        For Each oFD In .SelectedItems
            fileName = oFD
           
            'CampList.Text = CampList.Text & Mid(fileName, InStrRev(fileName, "\") + 1) & vbCrLf
            CampList.Text = fileName & vbCrLf
        Next oFD
        On Error GoTo 0
    End With
       
    Set fd = Nothing

Once the user is satisfied with the files selected, they press a button to open each sheet in turn and import the data into the main sheet "Import"

This is where I'm getting stuck. My list of files will be something like this, with only the filenames shown.

1. Big Report 21-02-2020.xlsx

2. Coach report 04-05-2020.xlsx

3. Christmas report 11-11-2020.xlsx

Should I preface each opening with a variable string pName (pathname) that ideally would be chosen for where the files are opened, right? Like below

pName = Left(fileName, InStr(fileName, "\") + 1)

(Obviously I'd jiggle the +1 depending on what gets spat out at me)

So I need to loop through the reports, open the first one, do the data shenanigans (I should be ok writing this code) and then close the workbook and find the next filename in the list. This is where I'm getting stuck, because I don't know how to split one or more strings by the carriage return? I essentially want to write something like:

Do until list of all workbooks is exhausted
Set wb = workbooks.open(pName & [somehow determined first file name])
'doing all my copy-pasting stuff here
Wb.close 
Loop

Lol.. What a mess of a question. Cheers.

 

[Fluff]

I would suggest putting the file names into a listbox, rather than a textbox. Is that ok?

 

[RockandGrohl]

I would suggest putting the file names into a listbox, rather than a textbox. Is that ok?

Would the list box show all items in one go, it won't have a drop down?

Cheers.

 

[Fluff]

Would the list box show all items in one go

Yes

 

[RockandGrohl]

Cool, I've now got this but it's having a wobbly:

    Set fd = Application.FileDialog(msoFileDialogFilePicker)
    With fd
        .ButtonName = "Select"
        .AllowMultiSelect = True
        .InitialFileName = "\\chw-dc03\company\Sales"
        .Filters.Add "Excel Files", "*.xls*", 1
        .Title = "Please choose a DM Report to open"
        .InitialView = msoFileDialogViewDetails
        .Show
        
        For Each oFD In .SelectedItems

            fileName = oFD
            pName = Left(fileName, InStrRev(fileName, "\"))
            'CampList.Text = CampList.Text & Mid(fileName, InStrRev(fileName, "\") + 1) & vbCrLf
            ListBox1.AddItem = " & Mid(fileName, InStrRev(fileName, " \ ") + 1) & "
            'CampList.Text = fileName & vbCrLf
        Next oFD
        On Error GoTo 0
    End With
       
    Set fd = Nothing

It now says expected function or variable

 

[Fluff]

Replace your loop with this

      For i = 1 To .SelectedItems.Count
         Me.ListBox1.AddItem .SelectedItems(i)
      Next i

 

[RockandGrohl]

Runtime error 424 - Object Required

Also, what I need to do is trim the path down to just show the file name, then later when I loop through to open them, I'm planning to append it with workbooks.open = pName & Listbox Item 1, etc.

 

[nemmi69]

Here is a way to break up the string if you do not want to use SPLIT and put the names in an array

Sub fgfgf()
Dim Tstr As String
Dim TrimStr As String
Dim ExctStr As String
Dim CrLoc As Integer
Dim TCell As Integer

Tstr = "Bob" & vbCrLf & "Tom" & vbCrLf & "Harry" & vbCrLf & "****" & vbCrLf
TrimStr = Tstr
TCell = 0
CrLoc = InStr(1, TrimStr, vbCrLf)

Do While CrLoc > 0
    
    'Find name
    ExctStr = Left(TrimStr, CrLoc - 1)
    'The extracted name can now be used. In this case write to cells
    TCell = TCell + 1
    Range("A" & TCell).Value = ExctStr
    'remove used name
    TrimStr = Right(TrimStr, Len(TrimStr) - CrLoc)
    CrLoc = InStr(1, TrimStr, vbCrLf)

Loop

 

[Fluff]

How about

   Dim fd As FileDialog
   Dim i As Long

   Set fd = Application.FileDialog(msoFileDialogFilePicker)
   With fd
      .ButtonName = "Select"
      .AllowMultiSelect = True
      .InitialFileName = "\\chw-dc03\company\Sales"
      .Filters.Add "Excel Files", "*.xls*", 1
      .Title = "Please choose a DM Report to open"
      .InitialView = msoFileDialogViewDetails
      .Show
      For i = 1 To .SelectedItems.Count
         Me.ListBox1.AddItem Split(.SelectedItems(i), "\")(UBound(Split(.SelectedItems(i), "\")))
      Next i
      Me.TextBox1.Value = Left(.SelectedItems(1), InStrRev(.SelectedItems(1), "\") - 1)
   End With
   
   Set fd = Nothing

If you will always be selecting files from the Sales folder then you can get rid of the textbox

 

[RockandGrohl]

I'll give your code a shot, but I will be selecting files from one of three locations. However, once a file is selected that location will be the only location for this process, if that makes sense?