Simple Copy/Paste VBA is copying the same data multiple times :(

[amandabstewart]

this works, BUT, when I run the macro again, it copies old data as new at the bottom. it's ok for it to overwright content in A2 on the destination page, but it takes the data like it is new and I get repeat data in the destination table.
any ideas? trying to delete either of the set pastecell parts causes the macro to die



Option Explicit

Sub CopyP2()

Dim PatientCol As Range
Dim Patient As Range
Dim PasteCell As Range

Set PatientCol = Sheet1.Range("A2:A99")

For Each Patient In PatientCol


If Sheet4.Range("A2") = "" Then

Set PasteCell = Sheet4.Range("A2")
Else

Set PasteCell = Sheet4.Range("A1").End(xlDown).Offset(1, 0)
End If

If Patient = "P2" Then Patient.EntireRow.Copy PasteCell

Next Patient

End Sub

 

[Fluff]

Well my script copies the data to sheet(2) you never mentioned sheet named P2

Try reading post#5

 

[Fluff]

it is listed as sheet2 (P2) on the module list...

Is it Sheet2 or Sheet4?

 

[My Aswer Is This]

My script does exactly what Fluff script does but copies it to sheet4

 

[amandabstewart]

Oops, forgot to add the offset

Sub amandabstewart()
   Sheet4.UsedRange.Offset(1).ClearContents
   With Sheet1
      .Range("a1").AutoFilter 1, "P2"
      .AutoFilter.Range.Offset(1).EntireRow.Copy Sheet4.Range("a2")
      .AutoFilterMode = False
   End With
End Sub

WAAAA-LAA! it works!
And, from both of your replies it reminds me that I have forgotten more than I knew. I went back to look at some of my previous macros and they are way more complicated. I guess if you don't use it you lose it

 

[amandabstewart]

My script does exactly what Fluff script does but copies it to sheet4

crap, sorry Sheet4(P2)

 

[Fluff]

but copies it to sheet4

No it doesn't, it copies it to the 2nd sheet in the workbook, which could be anything at all.

 

[Fluff]

WAAAA-LAA! it works!

Glad we could help & thanks for the feedback.

 

[My Aswer Is This]

crap, sorry Sheet4(P2)

What does that mean:
Sheet4(P2)

Cannot copy entire row to P2

 

[My Aswer Is This]

No it doesn't, it copies it to the 2nd sheet in the workbook, which could be anything at all.

That is because he never said what sheet.

 

[amandabstewart]

thank you both so much! crazy how there are so many ways to code the same result...just like different ways to tell the same story I guess.