Strange Userform Error

[AndrewKent]

I'm having a bit of an issue with two userforms.

I have a workbook containing quite a few userforms in it, each that has an initialize routine calling different private macros specific to them.

Problem is that I have one userform with one macro that is being called anytime I launch ANY userform??? It's very strange.

What could be causing this?

 

[AndrewKent]

If it's also helpful,

each userform has a Private "Sub UserForm_Initialize()" routine that is carried out on opening.

 

[yytsunamiyy]

Without looking at your vba project its near impossible to say what is causing that. To give us a starting point - what is the sub that ALWAYS fires called?

 

[Gettingbetter]

Whats the macro called?

Can you post some of your code

 

[AndrewKent]

Okay sorry guys for being so vauge...

I found the macro that is causing the problem...

Sub LoadConversation()

'   =============================================================================================
'   This macro will load up the conversation anytime there is a change in multipages or
'   userforms.
'   =============================================================================================

    Dim Brand As String

    Brand = Worksheets("Data Capture").Range("C11").Value

    frmInboundIntro.txtFPDirect11.Value = Worksheets("Conversation").Range("G69").Value
    frmInboundIntro.txtCustomerDirect1.Value = Worksheets("Conversation").Range("G59").Value
    frmInboundIntro.txtStakeholder1.Value = Worksheets("Conversation").Range("G41").Value
    frmInboundIntro.txtStakeholder21.Value = Worksheets("Conversation").Range("G50").Value
    frmInboundIntro.txtStakeholder22.Value = Worksheets("Conversation").Range("G52").Value
    frmInboundIntro.txtOutbound11.Value = Worksheets("Conversation").Range("G18").Value
    frmInboundIntro.txtOutbound12.Value = Worksheets("Conversation").Range("G20").Value
    frmInboundIntro.txtOutbound21.Value = Worksheets("Conversation").Range("G23").Value
    frmFunnel.txtMandatory1.Value = Worksheets("Conversation").Range("G113").Value
    frmPersonalDetails.txtPersonalDetails11.Value = Worksheets("Conversation").Range("G215").Value
    frmCallClose.txtCallClose1.Value = Worksheets("Conversation").Range("G243").Value
    frmCallClose.txtCallClose3.Value = Worksheets("Conversation").Range("G248").Value
    frmCallClose.txtCallClose4.Value = Worksheets("Conversation").Range("G250").Value
    frmCallClose.txtCallClose5.Value = Worksheets("Conversation").Range("G252").Value
    frmCallClose.txtClose5.Value = Worksheets("Conversation").Range("G235").Value
    frmGCB3.txtSourceOfFunds1.Value = Worksheets("Conversation").Range("G259").Value
    frmTFDirectInvestment.txtSourceOfFunds1.Value = Worksheets("Conversation").Range("G259").Value
    frmTFISA.txtSourceOfFunds1.Value = Worksheets("Conversation").Range("G259").Value
    frmCombiBond.txtSourceOfFunds1.Value = Worksheets("Conversation").Range("G259").Value

    frmPersonalDetails.lblCustomer1.Caption = "Are you an existing " & Brand & " customer?"

    frmInboundIntro.txtOutbound27.Value = Worksheets("Calculation Matrix").Range("CalculationMatrix_C1FullName").Value

End Sub

...this is being called on initializing EVERY userform...I think I've f*cked up here in that by loading the conversation into each of these labels, it is infact opening ALL the userforms mentioned here?

 

[Gettingbetter]

Just as a quick fix,

at the top of your module (not forms) the place where you have your subs, put

Global RunFormIntProcess As Boolean

Then at the start of your initialize events on your userforms put the code

if RunFormIntProcess = true then exit sub

Then at the start of your sub put

RunFormIntProcess = true

and at the end of your sub put

RunFormIntProcess = false

What this will do is make sure the other forms dont initialize while your running the sub

hope this makes sence

Cheers
GB

 

[RoryA]

I think I've f*cked up here in that by loading the conversation into each of these labels, it is infact opening ALL the userforms mentioned here?

That is correct. As soon as you refer to a userform, you load an instance of it. So in actual fact, the forms are not calling the sub, it is calling them by the looks of it.

 

[AndrewKent]

Right, quick update to the LoadConversation routine and it now works fine...

Sub LoadConversation()

'   =============================================================================================
'   This macro will load up the conversation anytime there is a change in multipages or
'   userforms.
'   =============================================================================================

    Dim Brand As String

    Brand = Worksheets("Data Capture").Range("C11").Value

    If Worksheets("Calculation Matrix").Range("CalculationMatrix_CurrentUserform").Value = "frmInboundIntro" Then
        frmInboundIntro.txtFPDirect11.Value = Worksheets("Conversation").Range("G69").Value
        frmInboundIntro.txtCustomerDirect1.Value = Worksheets("Conversation").Range("G59").Value
        frmInboundIntro.txtStakeholder1.Value = Worksheets("Conversation").Range("G41").Value
        frmInboundIntro.txtStakeholder21.Value = Worksheets("Conversation").Range("G50").Value
        frmInboundIntro.txtStakeholder22.Value = Worksheets("Conversation").Range("G52").Value
        frmInboundIntro.txtOutbound11.Value = Worksheets("Conversation").Range("G18").Value
        frmInboundIntro.txtOutbound12.Value = Worksheets("Conversation").Range("G20").Value
        frmInboundIntro.txtOutbound21.Value = Worksheets("Conversation").Range("G23").Value
        frmInboundIntro.txtOutbound27.Value = Worksheets("Calculation Matrix").Range("CalculationMatrix_C1FullName").Value
        Exit Sub
    End If
    
    If Worksheets("Calculation Matrix").Range("CalculationMatrix_CurrentUserform").Value = "frmFunnel" Then
        frmFunnel.txtMandatory1.Value = Worksheets("Conversation").Range("G113").Value
        Exit Sub
    End If
    
    If Worksheets("Calculation Matrix").Range("CalculationMatrix_CurrentUserform").Value = "frmInboundIntro" Then
        frmPersonalDetails.txtPersonalDetails11.Value = Worksheets("Conversation").Range("G215").Value
        frmPersonalDetails.lblCustomer1.Caption = "Are you an existing " & Brand & " customer?"
        Exit Sub
    End If
    
    If Worksheets("Calculation Matrix").Range("CalculationMatrix_CurrentUserform").Value = "frmCallClose" Then
        frmCallClose.txtCallClose1.Value = Worksheets("Conversation").Range("G243").Value
        frmCallClose.txtCallClose3.Value = Worksheets("Conversation").Range("G248").Value
        frmCallClose.txtCallClose4.Value = Worksheets("Conversation").Range("G250").Value
        frmCallClose.txtCallClose5.Value = Worksheets("Conversation").Range("G252").Value
        frmCallClose.txtClose5.Value = Worksheets("Conversation").Range("G235").Value
        Exit Sub
    End If
    
    If Worksheets("Calculation Matrix").Range("CalculationMatrix_CurrentUserform").Value = "frmGCB3" Then
        frmGCB3.txtSourceOfFunds1.Value = Worksheets("Conversation").Range("G259").Value
        Exit Sub
    End If
    
    If Worksheets("Calculation Matrix").Range("CalculationMatrix_CurrentUserform").Value = "frmTFDirectInvestment" Then
        frmTFDirectInvestment.txtSourceOfFunds1.Value = Worksheets("Conversation").Range("G259").Value
        Exit Sub
    End If
    
    If Worksheets("Calculation Matrix").Range("CalculationMatrix_CurrentUserform").Value = "frmTFISA" Then
        frmTFISA.txtSourceOfFunds1.Value = Worksheets("Conversation").Range("G259").Value
        Exit Sub
    End If
    
    If Worksheets("Calculation Matrix").Range("CalculationMatrix_CurrentUserform").Value = "frmCombiBond" Then
        frmCombiBond.txtSourceOfFunds1.Value = Worksheets("Conversation").Range("G259").Value
        Exit Sub
    End If

End Sub

...it now only loads what it needs.

Cheers for the help guys!

 

[RoryA]

Wouldn't it make more sense to pass a value directly to the LoadConversation routine so it knows what it's updating, rather than having it read a worksheet cell?