String value being overwritten

[sheri100]

I have some code that loop through ranges and concatenates strings together based on dates. When I print it out it works correctly but when I try to assign the strings to cells ith doesn't work correctly.

This works:

debug.print strNewName

and gives me the correct output
Prime1
Prime1 Prime2
Prime2 prime3

This does not:

owData.Range("B" & rngTypeCell.Row).Value = strNewName

and gives me something like this (always repeating the previous cell value)

Prime1
Prime 1 Prime1 Prime2
Prime 1 Prime1 Prime2 Prime2 prime3

Any suggestions on how to fix this?

Thanks

 

[Greg Truby]

Making some assumptions about your naming conventions (good to see those, BTW), but nothing jumps out at me. I would set a watch on strNewName and step the code using your F8 key.

 

[sheri100]

Thanks, I didn't see any reason it was happening . I'm clearing the variable. Here is the entire section of code. I'm new to this so it may not be pretty.

   Set rngLob = Range("E2:E65000")
    Set rngPolicyNames = Range("B2:B65000")
    For Each rngLobCell In rngLob
 
        'prevLob = owData.Range("E" & rngLobCell.Row).Value
        strNewName = ""
 
        For Each rngPolicyNamesCell In rngPolicyNames
            If rngPolicyNamesCell.Row = rngLobCell.Row Then
                'values gets set here
                strNewName = strNewName & " " & owPolicies.Range("B" & rngPolicyNamesCell.Row).Value
                Exit For
            End If
 
            If owData.Range("E" & rngPolicyNamesCell.Row).Value = "" Then
 
                If StrComp(Range("E" & rngLobCell.Row).Value, Range("E" & rngPolicyNamesCell.Row).Value, vbTextCompare) = 0 Then
                    strNewName = strNewName & " " & owPolicies.Range("B" & rngPolicyNamesCell.Row).Value
            End If
 
            ElseIf CDate(owData.Range("E" & rngPolicyNamesCell.Row)) > CDate(owPolicies.Range("C" & rngLobCell.Row)) Then
 
                If StrComp(Range("E" & rngLobCell.Row).Value, Range("E" & rngPolicyNamesCell.Row).Value, vbTextCompare) = 0 Then
 
                    strNewName = strNewName & " " & owPolicies.Range("B" & rngPolicyNamesCell.Row).Value
 
                End If
 
            End If
 
        Next rngPolicyNamesCell
 
    'fix here
       owPolicies.Range("B" & rngLobCell.Row).Value = strNewName
       ' MsgBox strNewName
       'Debug.Print strNewName
 
        If owData.Range("A" & rngPolicyNamesCell.Row).Value = "" Then
              Exit For
        End If
 
    Next rngLobCell

 

[sheri100]

Figured it out, I was referencing the wrong sheet here:

If owData.Range("A" & rngPolicyNamesCell.Row).Value = "" Then
              Exit For
        End If

Thanks for the help.