Sumtimes code works other times it doesnt

[Hlatigo]

This peice of code is just suppose to create the new month and year if the directory doesnt exist. At times when I test, it will create the path but then if I try to run again, it will not save if the month already exists. I took this piece of code from a posting but havent been able to get it to work smoothly. any ideas?

thanks so much!

    prmptyear = Format(x1, "YYYY")
    prmptmonth = Format(x1, "MMM")
    fpath = "S:\USA-HOUSTON\FAMM\jcb39tfm\Bunker Price Reporting" & "\" & prmptyear & "\" & prmptmonth     '____
    fname1 = "BunkerPR_" & Format(x1, "mmddyyyy")                               
    fwrkbk1 = fname1 & ".xls"                                                            
    filenme1 = fpath & "\" & fwrkbk1                                                     
    


If Len(Dir(fpath)) > 0 Then
        ActiveWorkbook.SaveAs Filename:=filenme1
    
    Else
        MkDir Len(Dir(fpath))
    End If
    
    ActiveWorkbook.SaveAs Filename:=filenme1

 

[Hlatigo]

so i have made the following changes based on another posting and I seem to even get a worse result. hahaha I am going backwards here

Sub createdated()
    Dim x1
    
    
    
     x1 = Sheets("Main").Range("G7").Value
     
     If x1 = "" Then
        MsgBox ("Please Enter Date")
        End
     End If
     
    prmptyear = Format(x1, "YYYY")
    prmptmonth = Format(x1, "MMM")
    fpath = "S:\USA-HOUSTON\FAMM\jcb39tfm\Bunker Price Reporting" & "\" & prmptyear & "\" & prmptmonth
    fname1 = "BunkerPR_" & Format(x1, "mmddyyyy")
    fwrkbk1 = fname1 & ".xls"
    filenme1 = fpath & "\" & fwrkbk1
    
     
    If Len(Dir(fpath)) > 0 Then
        MkDir Len(Dir(fpath))
    End If
    
    ActiveWorkbook.SaveAs Filename:=filenme1

 

[jindon]

Not sure if this is what you wanted

Sub test()
Dim myDate As Date, myDir As String, fn As String
With Sheets("Main").Range("G7")
    If (.Value = "") + (Not IsDate(.Value)) Then
        MsgBox "Please Enter Date"
        Exit Sub
    End If
    myDate = .Value
End With
myDir = "S:\USA-HOUSTON\FAMM\jcb39tfm\Bunker Price Reporting\" & _
          Year(myDate) & "\" & MonhtName(Month(myDate), True)
fn = BunkerPR_"  & Format$(myDate, mmddyyyy") & ".xls" 
If Dir(myDir, vbDirectory) = "" Then MkDir myDir
ActiveWorkbook.SaveAs myDir & "\" & fn
End Sub