thisWB.close closes ALL workbooks, not just the one specified!

[thenapolitan]

Hey All,

You guys have been a big help before. Hopefully we can get something going again.

So, I have been using the following code. Works PERFECTLY on my computer, but when I move it over to another computer it closes ALL the Workbooks and leaves me with a blank Excel application open.

Any ideas on why it is closing everything on a different computer, but works fine on mine? I'm pulling my hair out here! This shouldn't be this complicated. Both computers running Office Professional 2016. Mine is Windows 8.1, the other computer is Windows 7.

    Dim thisWB as Workbook, importWB as Workbook, miscWB as Workbook

    set thisWB = ThisWorkbook
    set importWB = Workbooks.Open(filepath & filename)

    'do some processing and importing and stuff

    For Each miscWB In Workbooks
        If Not (miscWB Is ThisWorkbook) Then miscWB.Close SaveChanges:=false
    Next miscWB

Cheers,

thenapolitan

 

[Trebor76]

Hi thenapolitan,

Not sure why the code works on your machine and not others but see if changing this line of code...

If Not (miscWB Is ThisWorkbook) Then miscWB.Close SaveChanges:=False

...with this does the job:

If miscWB.Name <> ThisWorkbook.Name Then miscWB.Close SaveChanges:=False

HTH

Robert

 

[thenapolitan]

Hi Robert,

Thanks for the response! So, I changed my code to make it even more simple:

Went from this:

    [COLOR=#333333]Dim thisWB as Workbook, importWB as Workbook, miscWB as Workbook
[/COLOR]
    set thisWB = ThisWorkbook
    set importWB = Workbooks.Open(filepath & filename)

    'do some processing and importing and stuff

    For Each miscWB In Workbooks
        If Not (miscWB Is ThisWorkbook) Then miscWB.Close SaveChanges:=false
[COLOR=#333333]    Next miscWB
[/COLOR]

To this:

    [COLOR=#333333]Dim thisWB as Workbook, importWB as Workbook
[/COLOR]
    set thisWB = ThisWorkbook
    set importWB = Workbooks.Open(filepath & filename)

    'do some processing and importing and stuff
    
    importWB.Close

Seems WAY simpler, right? But it still attempts to close thisWB. I'm wondering if I have an "ActiveWorkbook" tag somewhere causing this to close. Will search on that as well, but I don't think I used that.

 

[thenapolitan]

Okay - I FOUND IT! I had an "ActiveWorkook" tag in my "importWB" that was causing it all to close! Crazy! It's all fixed (I think) and seems to place nice now.

Thanks for the help and getting me to think.

 

[thenapolitan]

Okay - I FOUND IT! I had an "ActiveWorkook" tag in my "importWB" that was causing it all to close! Crazy! It's all fixed (I think) and seems to place nice now.

So, nope, I haven't found the culprit here. It still attempts to close both "importWB" and "thisWB" only on the Windows 7 computers when I attempt to use

importWB.close

Ugh - I might pull what's left of my hair out because of this!