Tidy/Shorten my code?

[danbates]

Hi ,

I have this VBA code that works fine but I was wondering if there was a way of shortening it so it looks better?

'FOR LINE J SLIPSHEET HOLDER
Application.EnableEvents = False
If Target.Column = 5 And Range("E" & Selection.Row) = "J" Or Range("E" & Selection.Row) = "j" And Range("F" & Selection.Row) = 3 _
Or Target.Column = 5 And Range("E" & Selection.Row) = "J" Or Range("E" & Selection.Row) = "j" And Range("F" & Selection.Row) = 12 _
Or Target.Column = 5 And Range("E" & Selection.Row) = "J" Or Range("E" & Selection.Row) = "j" And Range("F" & Selection.Row) = 16 _
Or Target.Column = 5 And Range("E" & Selection.Row) = "J" Or Range("E" & Selection.Row) = "j" And Range("F" & Selection.Row) = 19 Then
MsgBox "Please make sure the slip sheet holder is locked in the correct position."
Application.EnableEvents = True
End If

Also in the near future I will be need this code to also work on Lines N, L and K. So if it's possible to add these lines in to a new code, then that would be great.

Any help would be appreciated.

Thanks

Dan

 

[GWteB]

A more readable code could look like below. Not sure what you're doing, since you are using the Selection Range object. In most cases it would return the same Range object as Target. Anyway, try this.

If Target.Column = 5 Then
    If UCase(Range("E" & Selection.Row)) = "J" Then
        Select Case Range("F" & Selection.Row).Value
        Case 3, 12, 16, 19
            MsgBox "Please make sure the slip sheet holder is locked in the correct position."
        End Select
    End If
End If

 

[dave3009]

Hi

Try this:

Dim MyRows As String
MyRows = "|3|12|16|19|"

If Target.Column = 5 And LCase(Range("E" & Target.Row).Value) = "j" And InStrRev(MyRows, "|" & Range("F" & Target.Row).Value & "|") Then
MsgBox "Please make sure the slip sheet holder is locked in the correct position."
End If

 

[danbates]

Thank you GWteB & dave3009 for helping me on my code.

I am going to use GWteB code just because I understand more than dave3009's code.

Thanks

Dan