to many 'with this workbook'?

[earp_]

hi have this structure

With myTime
If .Value >= TimeSerial(cHour, cMinute, 0) And .Value < TimeSerial(nHour, nMinute, 0) Then
...
Worksheets("Sheet2").range(colSheet2).End(xlUp).Offset(1, 0).PasteSpecial xlValues

'####################
'Count previous column
If (IsEqual = False) Then

If WorksheetFunction.CountA(Sheets("Sheet2").Columns(pIndex)) > 0 Then

Lastrow = Sheets("Sheet2").range(pIndex & Sheets("Sheet2").Rows.Count).End(xlUp).Row


With Worksheets("Sheet2")
'close
'Worksheets("sheet3").range("E65536").End(xlUp).Offset(1, 0) = Worksheets("Sheet2").range(colPrevSheet2).End(xlUp)
...

where

With ThisWorkbook
Set mytime = Worksheets("Sheet1").range("J2")
End With

Could this structure give me any error if I'm instead on the active sheet5?
I mean instead of using

With myTime
If .Value >= TimeSerial(cHour, cMinute, 0) And .Value < TimeSerial(nHour, nMinute, 0) Then

is it better to write something like

If myTime.Value >= TimeSerial(cHour, cMinute, 0) And myTime.Value < TimeSerial(nHour, nMinute, 0) Then

so maybe i have less errors.
Somehow my code crash...and maybe is for this kind of errors

 

[Andrew Poulsom]

If you want to refer to Sheet1 in ThisWorkbook, be sure to include the dot qualifier in your With clause:

With ThisWorkbook
    Set mytime = .Worksheets("Sheet1").range("J2")
End With

 

[earp_]

in this case it gives me an error because my structure is

Sub closeFun
Application.OnTime mdNextTime1, "myFirstSub", , False
Ed Sub

Sub myFirstSub
..
With thisWorkbook
Set myTime = Worksheets("Sheet1").range("B2")
End With
...
mdNextTime1 = Now + TimeValue("00:00:01")
End Sub

if I put the '.' it gives me an error on

Application.OnTime mdNextTime1...

 

[Norie]

You shouldn't really use With End with for one line of code.

Set myTime = ThisWorkbook.Worksheets("Sheet1").Range("B2")

If that still errors we need to see the rest of the code.

 

[earp_]

it seems to work without the With.
The Last question is that if i'm seeing the chart sheet (called chartSheet)
it gives me an error on this line

If WorksheetFunction.CountA(Sheets("Sheet2").Columns(pIndex)) > 0 Then

it works instead if i'm seeing other sheets