Trapped in a Looping Hell!!

[goldenvision]

Any ideas what is wrong with the following code

Private Sub createMarqueRange()
'specify start sheet
Sheets("Cleaned Sewells (Full File)").Activate
'specify start points
cMRc = 3
currRow = 2
'when to stop
Do Until Cells(currRow, 1) = "x"
If Cells(currRow, 12).Value = cbo_Marques Then
Sheets("Cleaned Sewells (Full File").Range("B" & cMRc, "Q" & cMRc, "S" & cMRc, "T" & cMRc).Copy Sheets("Lookups").Range("C" & currRow)
currRow = currRow + 1
Sheets("Cleaned Sewells (Full File)").Select
Else
'do nothing
End If
cMRc = cMRc + 1
Application.StatusBar = cMRc
Loop
Application.StatusBar = False
End Sub

I think it is reading through a table of data and each time the Marque equals the Marque selected in a combo box it copies the value to a new sheet, increases the row count by one and carries on. Evidently that isn't happening.

Any pointers would be greatly appreciated.

 

[erik.van.geit]

Hi,

This part of the code got my attention

Do Until Cells(currRow, 1) = "x"
If Cells(currRow, 12).Value = cbo_Marques Then
...
currRow = currRow + 1

Questions:
Is there any cell with an "x", exactly an "x"
are you sure that the "if" line ever gets true?
else currRow will never get updated

and most important
why did you put

currRow = currRow + 1

or did you just mix up the variables cuurRow and cMRc

to be honest it is difficult to check out code without data

Did you step through the code using function key F8 and while having a look on your sheet?

kind regards,
Erik

 

[goldenvision]

Erik,
Thanks for the response.

I ended up changing my entire code to use a For-Next loop and it is now working.

Thanks
David

 

[erik.van.geit]

you're WELCOME!!

When I look again at this, couldn't you use a filter to avoid the loop?
filter column 12
copy+paste in one go
done