User Defined Function doesn't work

YasserKhalil

Well-known Member
Joined
Jun 24, 2010
Messages
803
Hi everybody
I've written the following function to extract two digits from a 14 digits and then use these two digits to return a string value
But it doesn't work as I expect
Code:
Function Governorate(strID As Variant) As String
Dim strGov As String
If Len(strID) = 14 Then
    strGov = Mid(strID, 8, 2)
    If strGov = "33" Then
    Governorate = "Sector1"
    ElseIf strGov = "02" Then
    Governorate = "Sector2"
    Else
    GoTo Err
    End If
End If
Err:
Governorate = ""
End Function
I want to fix it
 

Some videos you may like

Excel Facts

Workdays for a market open Mon, Wed, Friday?
Yes! Use "0101011" for the weekend argument in NETWORKDAYS.INTL or WORKDAY.INTL. The 7 digits start on Monday. 1 means it is a weekend.

VoG

Legend
Joined
Jun 19, 2002
Messages
63,650
Try

Code:
Function Governorate(strID As Variant) As String
If Len(strID) = 14 Then
    Select Case Mid(strID, 8, 2)
        Case "33": Governorate = "Sector1"
        Case "02": Governorate = "Sector2"
        Case Else: Governorate = ""
    End Select
End If
End Function
 

YasserKhalil

Well-known Member
Joined
Jun 24, 2010
Messages
803
Mr. VoG
Thanks a lot
Your code works fine but I still want to discover the faults in my code to learn from my faults...
 

VoG

Legend
Joined
Jun 19, 2002
Messages
63,650
With your original code you would need to add the line in red to bypass the error handler

Rich (BB code):
Function Governorate(strID As Variant) As String
Dim strGov As String
If Len(strID) = 14 Then
    strGov = Mid(strID, 8, 2)
    If strGov = "33" Then
    Governorate = "Sector1"
    ElseIf strGov = "02" Then
    Governorate = "Sector2"
    Else
    GoTo Err
    End If
End If
Exit Function
Err:
Governorate = ""
End Function
 

Subscribe on YouTube

Watch MrExcel Video

Forum statistics

Threads
1,106,926
Messages
5,514,205
Members
408,990
Latest member
fresse68

This Week's Hot Topics

  • Sort code advice please
    Hi, I have the code below which im trying to edit but getting a little stuck. This was the original code which worked fine,columns A-F would sort...
  • SUMPRODUCT with nested If statement
    Hi everyone, Hope you're all well. I'm hoping someone will be able to point me in the right direction with a problem I'm having with a SUMPRODUCT...
  • VBA - simple sort is killing me!
    Hello all! This should be so easy, but not for me, apparently! I have a table of data that can be of varying lengths and widths. My current macro...
  • Compare Two Lists
    I have two Lists and I need to be able to Identify differences between them. List 100 comes from a workbook - the other is downloaded form the...
  • Formula that deducts points for each code I input.
    I am trying to create a formula that will have each student in my class start at 100 points and then for each code that I enter (PP for Poor...
  • Conditional formatting formula required for day of week and a value
    Hi, I have a really simple spreadsheet where column A is the date, column B is the activity total shown as a number and column C states the day of...
Top