User Defined Function doesn't work

[YasserKhalil]

Hi everybody
I've written the following function to extract two digits from a 14 digits and then use these two digits to return a string value
But it doesn't work as I expect

Function Governorate(strID As Variant) As String
Dim strGov As String
If Len(strID) = 14 Then
    strGov = Mid(strID, 8, 2)
    If strGov = "33" Then
    Governorate = "Sector1"
    ElseIf strGov = "02" Then
    Governorate = "Sector2"
    Else
    GoTo Err
    End If
End If
Err:
Governorate = ""
End Function

I want to fix it

 

[VoG]

Try

Function Governorate(strID As Variant) As String
If Len(strID) = 14 Then
    Select Case Mid(strID, 8, 2)
        Case "33": Governorate = "Sector1"
        Case "02": Governorate = "Sector2"
        Case Else: Governorate = ""
    End Select
End If
End Function

 

[YasserKhalil]

Mr. VoG
Thanks a lot
Your code works fine but I still want to discover the faults in my code to learn from my faults...

 

[VoG]

With your original code you would need to add the line in red to bypass the error handler

Function Governorate(strID As Variant) As String
Dim strGov As String
If Len(strID) = 14 Then
    strGov = Mid(strID, 8, 2)
    If strGov = "33" Then
    Governorate = "Sector1"
    ElseIf strGov = "02" Then
    Governorate = "Sector2"
    Else
    GoTo Err
    End If
End If
Exit Function
Err:
Governorate = ""
End Function

 

[YasserKhalil]

Oh That's right
Thanks Mr. VOG
Pleased with your correction