Validation VBA Code - Needs improvements

[Trying2learnVBA]

Hello,

I am trying to compare if two different cells have the same value as in positive or negative. This is the code I have, but it keeps returning my desired output when both cells have the same sign (either both positive or both negative)

Sub Validations()
''''''''''''''''''''''''''''''''''''''''''''''
'Formulas to fill out counterparty validations'
''''''''''''''''''''''''''''''''''''''''''''''
Dim WS1 As Worksheet
Set WS1 = ThisWorkbook.Sheets("CounterParty MTM Validations")

With WS1
'BoA
  .Range("B3").Value = .Range("A18")
  .Range("B4").Value = .Range("F18")
  .Range("B8").Value = .Range("A18")
  .Range("B9").Value = .Range("D18")
If .Range("B10") >= 100000 Or .Range("B10") <= -100000 Then
    .Range("A10").Value = "CALL"
Else
    .Range("A10").Value = "NO CALL"
End If

'this is not working, it always returns "Changing position"
If .Range("A8") > 0 And .Range("A9") > 0 Then
    .Range("A11").Value = "Changing Positions"
Else
    .Range("A11").Value = ""
End If

'I would like the same cell "A11 to have the output "Changing position" if my conditions are met, but I am ok having the output in separate cells
If .Range("A8") < 0 And .Range("A9") < 0 Then
    .Range("A12").Value = "Changing Positions"
Else
    .Range("A12").Value = ""
End If


End With
End Sub

Thank you for any pointers

 

[Zot]

Any sample data when to meet or when to not meet condition?

 

[Trying2learnVBA]

Any sample data when to meet or when to not meet condition?

Ok,

So, If say, A8 is a positive number.
and A9 is also a positive number.
Then the position is changing.

The position can also change if both are negative numbers.
Any number.

It might be A8 is 1000
A9 is -300
In this case, result should be nothing. ""

The other two cases would be say,
A8 is 100
A9 is 400
Both are positive. Position changes.
A8 is -200
A9 is -50
Both are negative. Position changes

 

[Zot]

Try this

Sub Validations()
''''''''''''''''''''''''''''''''''''''''''''''
'Formulas to fill out counterparty validations'
''''''''''''''''''''''''''''''''''''''''''''''
Dim WS1 As Worksheet
Set WS1 = ThisWorkbook.Sheets("CounterParty MTM Validations")

With WS1
'BoA
  .Range("B3").Value = .Range("A18")
  .Range("B4").Value = .Range("F18")
  .Range("B8").Value = .Range("A18")
  .Range("B9").Value = .Range("D18")
If .Range("B10") >= 100000 Or .Range("B10") <= -100000 Then
    .Range("A10").Value = "CALL"
Else
    .Range("A10").Value = "NO CALL"
End If

'this is not working, it always returns "Changing position"
If (.Range("A8") > 0 And .Range("A9") > 0) Or (.Range("A8") < 0 And .Range("A9") < 0) Then
    .Range("A11").Value = "Changing Positions"
Else
    .Range("A11").Value = ""
End If

End With
End Sub

 

[Zot]

I did not see how you want to handle id number is zero, but sure you can handle that.

 

[Trying2learnVBA]

I did not see how you want to handle id number is zero, but sure you can handle that.

Hey thank you!!

If both numbers are zero, no action is needed. This is for collateral calls based on margin. Daily mark to market fluctuations.
The "Changing positions" is simply a reminder for which direction the trade is going. Instead of memorizing every single little rule. I need to set up a few more but I need to understand the process better first. Thanks again