variable

[gregpet]

Newbie question. I set a variable name (wbname=thisworkbook.fullname), but when I go to use the variable in a subroutine called right after it is set the debugger says the variable is "empty". What am I doing wrong. Thanks in advance.

 

[Joe4]

Can you post your code, so we can see what is going on?

 

[Andrew Poulsom]

How did you declare the variable? It needs to be at the top of the module, before any procedures. Then it is public and available to all procedures. Otherwise it is only available to the procedure in which it is declared.

 

[gregpet]

Here is the first part of the code

Private Sub Workbook_Open()
' open workbook startup macro
'
wbname = ThisWorkbook.fullname
wbpath = ThisWorkbook.Path

Sheets(1).Activate
If MsgBox("Good morning ! Would you like to update reports ??", vbYesNo, "") = vbNo Then
Sheets(1).Activate
End
End If

Application.ScreenUpdating = False
Call SheetsVisible
Call showprogress

'MsgBox "estimate dates / move estimate data"
Call copy_batting
Call Estimates2
Sheets(1).Activate
Userform1.CheckBox1.Value = True
DoEvents

then the subroutine where it fails - line windows.(wbname).activate is "empty"

Sub copy_batting()
'Batting Report
Application.ScreenUpdating = False
Windows(wbname).Activate
Sheets("E").Activate
Cells.Select
Selection.ClearContents
Workbooks.Open Filename:= _
wbpath & "batting.xls"
Cells.Select
Selection.Copy
Windows(wbname).Activate
Sheets("E").Select
ActiveSheet.Paste
Range("a1").Select
Application.CutCopyMode = False
Windows("batting.xls").Close
End Sub

 

[gregpet]

If I understand correctly, I needed to dim the variables so they could be used in other sub routines. I added the lines:

Dim wbname As String
Dim wbpath As String

but it still does not work.

 

[Norie]

You haven't actually declared any variables as far as I can see.