Vba already selected range sort

[CrashOD]

Sub Sort_D_Then_B()

ActiveWorkbook.Worksheets("Per Capita").Sort.SortFields.Clear

Sort_D_Then_B

s)

ActiveWorkbook.Worksheets ("Per Capita").Sort.SortFields.Add Key:=Range(_ "D:D"), SortOn:=xlSortOnValues, Order:=xlAscending, DataOption:=

x1SortNormal

ActiveWorkbook.Worksheets ("Per Capita").Sort.SortFields. Add Key:=Range(

"B:B"), Sorton:=xlSortOnValues, Order:=xlAscending, DataOption:=

x1SortTextAsNumbers

With ActiveWorkbook.Worksheets ("Per Capita").Sort

'.SetRange Rows (ActiveCells)

.Header = xlGuess

.MatchCase = False

.Orientation = x1TopToBottom

.SortMethod = xlPinyin

.Apply

ActiveCell.Offset(1, 0).Select

End With

End Sub.

For some reason it's not sorting it. It doesn't run into an error anymore. And I got it to select one cell afterwards just to clear the full selection. But it does not sort it at all.

 

[Joe4]

The line wrapping on your code is all messed up, but I assume that is just a copy/paste issue.
Please use code tags when posting your VBA code, and that should avoid that issue and allow us to easily copy and test your code.
See here for how to do that: How to Post Your VBA Code

It might be helpful if you also posted a small sample of data you are trying to run this on.

 

[Fluff]

Further to what Joe has said, you also need to change all the x1 to xl (lower case L not number one)

 

[CrashOD]

Sorry the one is actually an l I took a picture off my computer at work and use Google lens to copy paste and didn't realize that it was showing a one instead of an l.

Sub Sort_D_Then_B()

ActiveWorkbook.Worksheets("Per Capita").Sort.SortFields.Clear

Sort_D_Then_B

s)

ActiveWorkbook.Worksheets ("Per Capita").Sort.SortFields.Add Key:=Range(_ "D:D"), SortOn:=xlSortOnValues, Order:=xlAscending, DataOption:=

x1SortNormal

ActiveWorkbook.Worksheets ("Per Capita").Sort.SortFields. Add Key:=Range(

"B:B"), Sorton:=xlSortOnValues, Order:=xlAscending, DataOption:=

x1SortTextAsNumbers

With ActiveWorkbook.Worksheets ("Per Capita").Sort

'.SetRange Rows (ActiveCells)

.Header = xlGuess

.MatchCase = False

.Orientation = x1TopToBottom

.SortMethod = xlPinyin

.Apply

ActiveCell.Offset(1, 0).Select

End With

End Sub.

For some reason it's not sorting it. It doesn't run into an error anymore. And I got it to select one cell afterwards just to clear the full selection. But it does not sort it at all.

Sub Sort_D_Then_B()

ActiveWorkbook.Worksheets("Per Capita").Sort.SortFields.Clear

ActiveWorkbook.Worksheets ("Per Capita").Sort.SortFields.Add Key:=Range("D:D"), SortOn:=xlSortOnValues, Order:=xlAscending, DataOption:=xlSortNormal

ActiveWorkbook.Worksheets ("Per Capita").Sort.SortFields. Add Key:=Range("B:B"), Sorton:=xlSortOnValues, Order:=xlAscending, DataOption:=xlSortTextAsNumbers

With ActiveWorkbook.Worksheets ("Per Capita").Sort

' .SetRange Rows (ActiveCells)

.Header = xlGuess

.MatchCase = False

.Orientation = xlTopToBottom

.SortMethod = xlPinyin

.Apply

ActiveCell.Offset(1, 0).Select

End With

End Sub.

 

[CrashOD]

Sub Sort_D_Then_B()

ActiveWorkbook.Worksheets("Per Capita").Sort.SortFields.Clear

ActiveWorkbook.Worksheets ("Per Capita").Sort.SortFields.Add Key:=Range("D:D"), SortOn:=xlSortOnValues, Order:=xlAscending, DataOption:=xlSortNormal

ActiveWorkbook.Worksheets ("Per Capita").Sort.SortFields. Add Key:=Range("B:B"), Sorton:=xlSortOnValues, Order:=xlAscending, DataOption:=xlSortTextAsNumbers

With ActiveWorkbook.Worksheets ("Per Capita").Sort

' .SetRange Rows (ActiveCells)

.Header = xlGuess

.MatchCase = False

.Orientation = xlTopToBottom

.SortMethod = xlPinyin

.Apply

ActiveCell.Offset(1, 0).Select

End With

End Sub

2022 - WCT - Real Estate.xls
	B	C	D	E	F	G	H	I	J				N	O
320	01900039		U				690.71	704.81	775.29				20800	019-00-076-105-A
321	01900048		U				91.32	93.18	102.51				2750	019-00-075-097
322	01900053		U				195.93	199.93	219.92				5900	019-00-075-089
323	01900077		U				214.18	218.56	240.42				6450	019-00-084-039-C
324	01900078	10/04/2022	P	123			824.53	841.36	925.50				24830	019-00-084-043-B
325	01900090	10/04/2022	P	456			142.81	145.72	160.29				4300	019-00-085-035
326	01900102	10/04/2022	P	789			638.25	651.28	716.41				19220	019-00-085-040-A
327	01900103		U				292.22	298.19	328.01				8800	019-00-074-037
328	01900118		U				769.41	785.12	863.64				23170	019-00-075-075
329	01900119		U				38.52	39.31	43.24				1160	019-00-075-075-A-001
330	01900123		U				796.98	813.24	894.56				24000	019-00-074-043-B
331	01900155		U				631.25	644.15	708.58				19010	019-00-085-024-A-001
332	01900168		U				548.59	559.78	615.76				16520	019-00-085-027-A
333	01900178		U				614.34	626.88	689.57				18500	019-00-083-048
Real Estate

 

[CrashOD]

updated work sheet name to sample i shared. i need to next when code works make it work for any worksheet or book im in.

Sub Sort_D_Then_B()

ActiveWorkbook.Worksheets("Real Estate").Sort.SortFields.Clear

ActiveWorkbook.Worksheets("Real Estate").Sort.SortFields.Add Key:=Range("D:D"), SortOn:=xlSortOnValues, Order:=xlAscending, DataOption:=xlSortNormal

ActiveWorkbook.Worksheets("Real Estate").Sort.SortFields.Add Key:=Range("B:B"), SortOn:=xlSortOnValues, Order:=xlAscending, DataOption:=xlSortTextAsNumbers

With ActiveWorkbook.Worksheets("Real Estate").Sort

' .SetRange Rows (ActiveCells)

.Header = xlGuess

.MatchCase = False

.Orientation = xlTopToBottom

.SortMethod = xlPinYin

.Apply

ActiveCell.Offset(1, 0).Select

End With

End Sub

 

[Fluff]

Is you are selecting the range first try

Sub Sort_D_Then_B()

Selection.Sort Range("D:D"), xlAscending, Range("B:B"), , xlAscending

End Sub

 

[CrashOD]

Is you are selecting the range first try

Sub Sort_D_Then_B()

Selection.Sort Range("D:D"), xlAscending, Range("B:B"), , xlAscending

End Sub

thanks so much! lol such a simple line of code for my long code from altering from a recording i did.

if someone needs this code the searches for it

Sub Try()

'select cell C 10,000
ActiveSheet.Range("C10000").Select

' goes up to last drawer (blank cell) posted if cell is empty in C
Selection.End(xlUp).Select
' (not needed since C should be empty) Selection.End(xlUp).Select

' highlights cells below for sorting
Rows(ActiveCell.Row).Select
Range(Selection, Selection.End(xlDown)).Select

' Sorts D then B
Selection.Sort Range("D:D"), xlAscending, Range("B:B"), , xlAscending

'select cell C 10,000
ActiveSheet.Range("C10000").Select

' goes up to last drawer posted (last cell that has info) then goes down one
Selection.End(xlUp).Offset(1, 0).Select

' Inserts new line + make bold + color line
ActiveCell.EntireRow.Insert
ActiveCell.EntireRow.Font.Bold = True
Rows(ActiveCell.Row).Select
With Selection.Interior
.PatternColorIndex = xlAutomatic
.ThemeColor = xlThemeColorAccent6
.TintAndShade = 0.599993896298105
.PatternTintAndShade = 0
End With

End Sub