VBA - Check and run macro only once

j4ymf

Well-known Member
Joined
Apr 28, 2003
Messages
733
Office Version
  1. 365
Platform
  1. Windows
Morning

I have a macro, can some one please help me change it and write the code to check if the macro have run before when the button is pressed
if it has please return a message saying sorry this has be run before. then end the macro

my thoughts were to have a look and see if anything was in cell """" Destination:=Sheets("P1").Range("A13")) ""
if not run the macro

many thanks jason

Code:
Sub GetWebPage_P1()
    'Copy web page
    On Error GoTo error
    Application.ScreenUpdating = False
    
        With Sheets("P1").QueryTables.Add(Connection:= _
            "URL;" & Sheets("Data").Range("B22").Value, _
            Destination:=Sheets("P1").Range("A13"))
        
            .BackgroundQuery = True
            .TablesOnlyFromHTML = True
            .Refresh BackgroundQuery:=False
            .SaveData = True
        End With
        
         Sheets("Test").Activate
    Range("L12:Y764").Select
    Application.CutCopyMode = False
    Selection.Copy
    Sheets("P1").Select
    Range("L13").Select
    ActiveSheet.Paste
    Columns("L:L").ColumnWidth = 16.83
    Columns("V:V").ColumnWidth = 14.5
    Range("A1").Select
        
     
error:
Application.ScreenUpdating = True
End Sub
 

Excel Facts

Which Excel functions can ignore hidden rows?
The SUBTOTAL and AGGREGATE functions ignore hidden rows. AGGREGATE can also exclude error cells and more.

mole999

Well-known Member
Joined
Oct 23, 2004
Messages
10,524
Office Version
  1. 2019
  2. 2016
  3. 2013
Platform
  1. Windows
i just get the macro to place a charter on a sheet when run, and then when its called again check to see if the mark exists, if it does exit sub
 
Upvote 0

j4ymf

Well-known Member
Joined
Apr 28, 2003
Messages
733
Office Version
  1. 365
Platform
  1. Windows
mmm

thanks mole99
I've been thinking the same

can you write an example for me please or re write my code to suit?

I'm thinking something like this!

Code:
If ISBLANK(Sheets("P1").Range("A13"))= True
     MsgBox "Sorry, This button has already been pressed!"
Else
        With Sheets("P1").QueryTables.Add(Connection:= _
            "URL;" & Sheets("Data").Range("B22").Value, _
            Destination:=Sheets("P1").Range("A13"))
[\code]
 
Upvote 0

mole999

Well-known Member
Joined
Oct 23, 2004
Messages
10,524
Office Version
  1. 2019
  2. 2016
  3. 2013
Platform
  1. Windows
at the beginning of the code

If Sheets("P1").Range("A1")= "X" Then Exit Sub

at the end

Sheets("P1").Range("A1") = "X"
 
Upvote 0

j4ymf

Well-known Member
Joined
Apr 28, 2003
Messages
733
Office Version
  1. 365
Platform
  1. Windows
thank you mole ill give it a try
 
Upvote 0

Steph77

Board Regular
Joined
Sep 18, 2014
Messages
119
You should also probably put something in a workbook_beforeclose sub to remove the X if you want them to be able to save it and then run it next time it's opened.
 
Upvote 0

j4ymf

Well-known Member
Joined
Apr 28, 2003
Messages
733
Office Version
  1. 365
Platform
  1. Windows
mole

why can i get a message box to work

If Sheets("P2").Range("A1") = "x" ._
MsgBox "Sorry, This button has already been pressed!"Then Exit Sub

thanks for your help
 
Upvote 0

MARK858

MrExcel MVP
Joined
Nov 12, 2010
Messages
15,034
Office Version
  1. 365
Platform
  1. Windows
  2. Mobile
Or the "Then" being in the wrong place

Either...

Code:
Sub xxx()
    If Sheets("P2").Range("A1") = "X" Then MsgBox "Sorry, This button has already been pressed!"
    Exit Sub
End Sub

or

Code:
Sub XXX2()
    If Sheets("P2").Range("A1") = "X" Then
        MsgBox "Sorry, This button has already been pressed!"
        'OTHER ACTION
        'OTHER ACTION
        'OTHER ACTION
        Exit Sub
    End If
End Sub
 
Upvote 0

j4ymf

Well-known Member
Joined
Apr 28, 2003
Messages
733
Office Version
  1. 365
Platform
  1. Windows
sorry im still on this one
confusing me a little

how do i get in an else or somthing after the exit sub? if the button hassnt been pressed
or it does nothing???
thanks jason

Code:
Sub GetWebPage_P2()
    'Copy web page
    On Error GoTo error
    Application.ScreenUpdating = False
    
    If Sheets("P2").Range("A1") = "X" Then MsgBox "Sorry, This button has already been pressed!"
    Exit Sub
    
    
       With Sheets("P2").QueryTables.Add(Connection:= _
            "URL;" & Sheets("Data").Range("B23").Value, _
            Destination:=Sheets("P2").Range("A13"))
        
            .BackgroundQuery = True
            .TablesOnlyFromHTML = True
            .Refresh BackgroundQuery:=False
            .SaveData = True
        End With
        
        
        Sheets("Test").Activate
    Range("L12:Y920").Select
    Application.CutCopyMode = False
    Selection.Copy
    Sheets("P2").Select
    Range("L13").Select
    ActiveSheet.Paste
    Columns("L:L").ColumnWidth = 16.83
    Columns("V:V").ColumnWidth = 14.5
    Range("A1").Select
    
    Sheets("P2").Range("A1") = "X"
     
error:
Application.ScreenUpdating = True
End Sub
 
Upvote 0

Forum statistics

Threads
1,191,165
Messages
5,985,040
Members
439,935
Latest member
Monty238

We've detected that you are using an adblocker.

We have a great community of people providing Excel help here, but the hosting costs are enormous. You can help keep this site running by allowing ads on MrExcel.com.
Allow Ads at MrExcel

Which adblocker are you using?

Disable AdBlock

Follow these easy steps to disable AdBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the icon in the browser’s toolbar.
2)Click on the "Pause on this site" option.
Go back

Disable AdBlock Plus

Follow these easy steps to disable AdBlock Plus

1)Click on the icon in the browser’s toolbar.
2)Click on the toggle to disable it for "mrexcel.com".
Go back

Disable uBlock Origin

Follow these easy steps to disable uBlock Origin

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back

Disable uBlock

Follow these easy steps to disable uBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back
Top