VBA - code doesn't work in second macro

[WesStewart]

hey all, I'm pretty new to vba, and I could use some help
here is the code am using. This is just a basic macro to call another macro and loop. however, it seems to be skipping everything from "workbooks.open" through "activeworkbook.saveas"
the annoying bit is that I have used this code twice before but with different file names and paths and everything worked

I have stepped-through the code and it really just seems to be skipping those lines, which it does not do in the original code.

Any help would be greatly appreciated!

Sub oddball_macro_loop()
'
' oddball_macro_loop Macro
'
'

    Dim rawPath As String
    Dim rawFile As String
    Dim savePath As String
    Dim oWB As Workbook
    Dim fName As Variant
    
    
    rawPath = "I:\Cores\DMB\E-Prime Tasks\Salience Task\Data\Macros\Raw\For macro"
    rawFile = Dir(rawPath & "*.txt")
    savePath = "I:\Cores\DMB\E-Prime Tasks\Salience Task\Data\Macros\Processed"
    
    ChDir (rawPath)
    Application.DisplayAlerts = True
    
    Do While rawFile <> ""
        Workbooks.Open Filename:="I:\Cores\DMB\E-Prime Tasks\Salience Task\Data\Macros\oddball_macro.xlsm"
        Set oWB = Workbooks.Open(rawPath & rawFile)
        Application.Run "'oddball_macro.xlsm'!oddball_macro"
        Sheets("Data").Select
    
         
    'Sets File Name
        Dim text As String
        text = Range("Z12")
        fName = Mid(text, 19)
        ActiveWorkbook.SaveAs Filename:=savePath & fName, FileFormat:=xlOpenXMLWorkbook, CreateBackup:=False
        ActiveWorkbook.Close False
        rawFile = Dir()
    Loop
    
    ActiveWorkbook.Close False
    Application.ScreenUpdating = True

    
End Sub

 

[JLGWhiz]

When you stepped through the code, did it take you to 'oddball_macro'? I suspect that macro is not doing what you expect it to do, since there is nothing else in the posted macro that would do anything except select a sheet and save the file.

 

[WesStewart]

When you stepped through the code, did it take you to 'oddball_macro'? I suspect that macro is not doing what you expect it to do, since there is nothing else in the posted macro that would do anything except select a sheet and save the file.

I should clarify. The issue is that the macro I am calling does not load at all. No error messages are given, it just seems to skip over those sections entirely when doing the step-into. When I have used other versions of this code, the step-into loads the other macro

 

[JLGWhiz]

I should clarify. The issue is that the macro I am calling does not load at all. No error messages are given, it just seems to skip over those sections entirely when doing the step-into. When I have used other versions of this code, the step-into loads the other macro

I don't see anything wrong with the way the "oddball_macro" is called. You have opened the workbook it is in, so there should be no problem there. However, if all else fails, you can copy the procedure into the same workbook that you are now running the calling code from and modify the posted procedure to eliminate opening the oddball workbook and change the calling line to just:

oddball_macro

 

[Fluff]

ADVERTISEMENT

Hi
It looks as though both rawPath & savePath are missing a final \ should it be

    rawPath = "I:\Cores\DMB\E-Prime Tasks\Salience Task\Data\Macros\Raw\For macro\"
    rawFile = Dir(rawPath & "*.txt")
    savePath = "I:\Cores\DMB\E-Prime Tasks\Salience Task\Data\Macros\Processed\"

 

[WesStewart]

Hi
It looks as though both rawPath & savePath are missing a final \ should it be

    rawPath = "I:\Cores\DMB\E-Prime Tasks\Salience Task\Data\Macros\Raw\For macro\"
    rawFile = Dir(rawPath & "*.txt")
    savePath = "I:\Cores\DMB\E-Prime Tasks\Salience Task\Data\Macros\Processed\"

That was it! thank you!

 

[Fluff]

Glad to help & thanks for the feedback