vba code help

[isacp]

Sub Macro13()
'
' Macro13 Macro
' Macro recorded 1/18/2005 by isacp
'
' Keyboard Shortcut: Ctrl+Shift+N
'
For Each Item In Selection
If Item.Value = "NA" Then
Item.EntireRow.Delete
End If
Next Item
End Sub

this is my code
for some reason when i select say b1:b20
and all the cells have NA in it it only deletes 10

 

[Barrie Davidson]

Would this help you out?

Dim DelRange As Range
Dim RangeSet As Boolean

RangeSet = False
For Each Item In Selection
    If Item.Value = "NA" Then
        If RangeSet = False Then
            Set DelRange = Item
            RangeSet = True
        Else
            Set DelRange = Union(DelRange, Item)
        End If
    End If
Next Item
If RangeSet = False Then Exit Sub
DelRange.EntireRow.Delete

 

[isacp]

it worked great on the cells that have na but not all cells that im celecting have na.

and anyway i still cant figure out whats wrong wth my code?

 

[Barrie Davidson]

it worked great on the cells that have na but not all cells that im celecting have na.

It won't delete any cells that don't have na.

and anyway i still cant figure out whats wrong wth my code?

I think (not tested) it's because you're looping through a selection and the selection keeps getting smaller. That is, you're deleting rows each time na is found. My code finds all the na's and then deletes them all at once.

Regards,

 

[tactps]

The issue is that you are deleting a row (which then automatically selects the next row) and then you have a "next item" statement (which drops down two.

So if you have 3 "NA" in a row, the second one is missed.

I suggest that if you find an "NA" you restart the macro like this:

Sub Macro13()
'
' Macro13 Macro
' Macro recorded 1/18/2005 by isacp
'
' Keyboard Shortcut: Ctrl+Shift+N
'
For Each Item In Selection
If Item.Value = "NA" Then
Item.EntireRow.Delete
Macro13
End If
Next Item
End Sub