vba code to create a pdf giving error message

[JannetteChristie]

My code is as follows:

JobName = ActiveSheet.Range("Salesman") & " - Weekly Report: w/c " & Sheets("Analysis").Range("FromDate")
TempFileName = Environ$("temp") & "" & JobName & ".pdf"
' TempFileName = "c:\Users" & JobName & ".pdf"


ActiveSheet.ExportAsFixedFormat Type:=xlTypePDF, _
Filename:=TempFileName, _
OpenAfterPublish:=False

I am getting the error message Run-time error '-2147024773 (8007007b)': Document not saved.

Watch : : TempFileName : "C:\Users\jchri\AppData\Local\Temp\Frazer Ross - Weekly Report: w/c 04/06/2018.pdf"
Watch : : JobName : "Frazer Ross - Weekly Report: w/c 04/06/2018" : String : Module2.SubmitData

I have no idea what is wrong with the code - can anyone help ?

 

[Joe4]

I think your issue is with the file name. "/" are invalid characters for file name (in your "w/c 04/06/2018" part).
You cannot use those in your file name.

 

[JannetteChristie]

Thanks for that, however I have removed the slashes and still get the same error code.

?JobName
Frazer Ross - Weekly Report: w.c 04.06.2018
?TempFileName
C:\Users\jchri\AppData\Local\Temp\Frazer Ross - Weekly Report: w.c 04.06.2018.pdf

 

[Joe4]

Colons aren't allowed either in file names (missed that one earlier).

A good way to test/debug these sort of things is to try it on a simple name first, like "test.pdf".
If that works, but your big one doesn't, then you know the issue is with your file name.

 

[JannetteChristie]

Ok yes, thanks - all working now.