VBA Collection Items Get Overwritten


New Member
Mar 31, 2015
I am attempting to add form controls dynamically to a blank form, and build a collection of those controls so I can write my own events. I'm having limited success.

The controls are successfully adding to the form, appear to be adding to the collection, but my click() event only works for the last control on the form. When enumerating the collection, it appears that every item in the collection now holds a reference to only the last field.

When the form appears, five textboxes appear. Double clicking on the last field works, but none of the other 4.

Please ... save my brain from overload!

My class [cTextHandler]
Public WithEvents txt As MSForms.TextBox

Private Sub txt_DblClick(ByVal Cancel As MSForms.ReturnBoolean)
MsgBox (txt)
End Sub

My form [UserForm1]
Option Explicit

Dim collText As Collection

Private Sub UserForm_Initialize()

    Dim row As Integer
    Dim Prev As Integer
    Dim txt As Control
    'event handlers
    Dim txtH As cTextHandler
    Set txtH = New cTextHandler
    Set collText = New Collection

    'Add 5 text boxes to blank form
    Prev = 1
    MsgBox ("Adding items to Collection")
    For row = 1 To 5
        'Add Controls to Form and Build Collection
        Set txt = UserForm1.Controls.Add("Forms.TextBox.1", "foo" & row)
        With txt
            .Value = "foo" & row
            .Width = 168
            .Height = 18
            .Top = Prev + 20
            .Left = 5
            .ZOrder (0)
        End With
        Prev = Prev + 20
       'Add Controls to Collection
        Set txtH.txt = txt
        collText.Add txtH
        MsgBox (txtH.txt)
    Next row

    'Print out the collection
    Dim o As Object
    Dim t As cTextHandler
    MsgBox ("List the Collection")
    For Each o In collText
        Set t = o
        MsgBox (t.txt)
End Sub
Last edited by a moderator:

Some videos you may like

Excel Facts

Back into an answer in Excel
Use Data, What-If Analysis, Goal Seek to find the correct input cell value to reach a desired result


MrExcel MVP, Moderator
May 2, 2008
Office Version
365, 2019, 2016, 2010
Windows, MacOS
This line:
    Set txtH = New cTextHandler
needs to be inside your loop so that you create a new instance for each control.

Watch MrExcel Video

Forum statistics

Latest member

This Week's Hot Topics

  • Finding issue in If elseif else with For each Loop
    Finding issue in If elseif else with For each Loop I have tried this below code but i'm getting in Y column filled with W005. Colud you please...
  • MsgBox Error
    Hi Guys, I have the below error show up when i try and run my macro in File1 but works fine if i copy and paste the same code into file2. [ATTACH...
    My Cell Format is [B]""0.00" Cr". [/B]But in the cell, it is showing 123.00 for editing. (123 is entry figure). (Data imported from other...
  • Show numbers nearly the same
    Is this possible. I have a number that can change very time eg 0.00001234 Then I have a lot of numbers 0.0000001, 0.0000002, 0.00000004...
  • Please i need your help to create formula
    I need a formula in cell B8 to do this >>if b1=1 then multiply ( cell b8) by 10% ,if b1=2 multiply by 20%,if=3 multiply by 30%. Thank you in...
  • Got error while adding column and filter
    Got error while adding column and filter In column Z has some like "Success" and "Error". I want to add column in AA if the Z cell value is...