VBA - Concatenate Match Offset Loop

[MixedUpExcel]

Hi,

Detail of data:

Column A has a list of product codes (of which there can be duplicates upto 5000 duplicates but in some cases, there may only be 1)
Column B has a list of associated product codes (there may also be duplicates as more than one of the products in Column A can be associated with the products in Column B) - I don't think the duplicate issue will come in to this though

I have a unique list of product codes from Column A and these are placed under a header in Column J

I have a number from 1 to 5000 as headers in Cell K1 going to the right ->>>

I want a VBA code which will take the product code from Cell J2 - find the corresponding code in Column A and return the product code next to it in Column B and put that code in Cell K2

As there will be duplicates, I want the code to then move to Cell L2 and look for the next instance in Column A where it finds the product code from Cell J2 (the second instance) and puts the result in Cell L2 and so on until it can't find any more products (Cell J2) in Column A

Then, it moves to Row 3, Column J and does the process again until it can't find any more of the Product Code (Cell J3) in Column A.

I will have potentially 40,000 Unique Codes in Column J

I have a formula which can do this but takes FAR TOO LONG to process.

This is my formula:

{=INDEX(Sheet1!$B$2:$B$20000, SMALL(IF($J2=Sheet1!$A$2:$A$20000, ROW(Sheet1!$B$2:$B$20000)-MIN(ROW(Sheet1!$B$2:$B$20000))+1, ""), COLUMN(A1)))}

This is an example table as described above:

A

B

C

D

E

F

G

H

I

J

K

L

M

N

O

1

Product

Associated

Unique Product

1

2

3

4

5

2

AB123

XY1

AB123

XY1

XY4

XY1

XY4

#NUM!

3

AB124

XY2

AB124

XY2

XY5

XY2

XY5

#NUM!

4

AB125

XY3

AB125

XY3

XY6

XY3

XY6

#NUM!

5

AB126

XY4

AB126

XY4

XY5

XY1

XY2

XY4

6

AB126

XY5

AB127

XY6

XY3

XY6

#NUM!

7

AB127

XY6

AB128

XY1

XY4

XY1

#NUM!

8

AB128

XY1

AB129

XY2

XY5

XY2

#NUM!

9

AB129

XY2

AB130

XY3

XY6

XY3

#NUM!

10

AB130

XY3

11

AB123

XY4

12

AB124

XY5

13

AB125

XY6

14

AB126

XY1

15

AB126

XY2

16

AB127

XY3

17

AB128

XY4

18

AB129

XY5

19

AB130

XY6

20

AB123

XY1

21

AB124

XY2

22

AB125

XY3

23

AB126

XY4

24

AB126

XY5

25

AB127

XY6

26

AB128

XY1

27

AB129

XY2

28

AB130

XY3

29

AB123

XY4

30

AB124

XY5

31

AB125

XY6

32

AB126

XY1

<colgroup><col span="2"><col><col span="7"><col><col span="5"></colgroup><tbody>
</tbody>

My thoughts were to possibly concatenate the unique codes in Column J with the header number (have an inserted Column at the start - a new Column A possibly) and using Countif eg. =Countif($A$2:A2,A2) in the new Column A - give me the number in the Count which I can concatenate in a new column and do a look up that way - or match / offset etc.

Is there any way to do the above or is there a better solution?

Thanks in advance.

Simon

 

[MixedUpExcel]

Hi,

I've put the below code together which mostly does what I want.

If anyone sees this posts and can suggest something better, please let me know.

Sub test2()

Dim x As String
Dim y As String
Dim m As String


For a = 2 To 1400
For z = 11 To 500


x = Cells(a, 10)
y = Cells(1, z)


m = y & x


numRow = Application.Match(m, Range("c:c"), 0)


If IsError(numRow) = False Then
    Cells(a, z).Value = Range("d1").Offset(numRow - 1)
Else
    
   GoTo NEXTROW
   
End If


Next


NEXTROW:


Next


End Sub

Thanks.

Simon

 

[Fluff]

Do you want duplicates codes in K, L etc as you have shown, or just the unique values like

Excel 2013/2016
	J	K	L	M	N
2	AB123	XY1	XY4
3	AB124	XY2	XY5
4	AB125	XY3	XY6
5	AB126	XY4	XY5	XY1	XY2
6	AB127	XY6	XY3
7	AB128	XY1	XY4
8	AB129	XY2	XY5
9	AB130	XY3	XY6
T

 

[MixedUpExcel]

Hi Fluff,

I hadn't even noticed that - I'd done that with the formula and dragged across (I think I must have missed a $ sign somewhere or something as it usually works ok (or so I think))

I've got the coding doing what I needed now, so won't need the formula now.

Thanks for letting me know though, it's worth checking to make sure it is only a simple error on my side of things.

Simon

 

[Fluff]

If you just want the unique values try

Sub MixedUpExcel()
   Dim Ary As Variant, Ky As Variant
   Dim Dic As Object
   Dim i As Long
   
   Ary = Range("A1").CurrentRegion.Value2
   
   Set Dic = CreateObject("scripting.dictionary")
   For i = 2 To UBound(Ary)
      If Not Dic.Exists(Ary(i, 1)) Then Dic.Add Ary(i, 1), CreateObject("scripting.dictionary")
      Dic(Ary(i, 1))(Ary(i, 2)) = Empty
   Next i
   i = 0
   With Range("J" & Rows.Count).End(xlUp).Offset(1)
      For Each Ky In Dic.Keys
         .Offset(i).Value = Ky
         .Offset(i, 1).Resize(, Dic(Ky).Count).Value = Dic(Ky).Keys
         i = i + 1
      Next Ky
   End With
End Sub

 

[MixedUpExcel]

Thanks Fluff,

I've tried running it but I'm not sure what I'm expecting it to do?

I've got my product codes in Column A / associated codes in Column B and the unique list of product codes in Column J.

When I run your code, nothing seems to happen and then after a while, I get the following message:

Run-time error '1004':
Application-defined or object defined error

Thanks.

 

[Fluff]

Firstly you don't need the list in col J, the macro will put them in for you.
Secondly when you get the error click debug, what line is highlighted?

 

[MixedUpExcel]

Hi Fluff,

Error appears to be against line:

.Offset(i, 1).Resize(, Dic(Ky).Count).Value = Dic(Ky).Keys

Thanks.

 

[MixedUpExcel]

Firstly you don't need the list in col J, the macro will put them in for you.
Secondly when you get the error click debug, what line is highlighted?

Hi Fluff,

Thank you for taking the time to create that piece of code for me.

A lot of that is beyond my current understanding but I'm more than happy to learn more.

I hadn't realised at first that your code was bypassing some of the processes I thought I need and speeding it up to such an amazingly quick pace.

Really appreciate it.

Thank you for your help again.

Simon


Edit:

If this makes any difference - this is from my actual sheet:

Column A and B have 162,820 rows

When I got the error message, it had put in the Product Code in Column J on Row 7570 BUT it hadn't put in the first Associated code into Cell K7570 (it just stopped there)

The Product Code in Cell J7570 first appears in Column A on Row 108431

I've put the above because I don't know if there are any limitations to the code you've provided me with regards to number of rows it can deal with etc.

Thanks.

 

[Fluff]

Clear column J & run this

Sub MixedUpExcelTest()
   Dim Ary As Variant, Ky As Variant
   Dim Dic As Object
   Dim i As Long
   
   Ary = Range("A1").CurrentRegion.Value2
   
   Set Dic = CreateObject("scripting.dictionary")
   For i = 2 To UBound(Ary)
      Dic(Ary(i, 1)) = Dic(Ary(i, 1)) + 1
   Next i
   i = 0
   With Range("J" & Rows.Count).End(xlUp).Offset(1)
      For Each Ky In Dic.Keys
         .Offset(i).Resize(, 2).Value = Array(Ky, Dic(Ky))
         i = i + 1
      Next Ky
   End With
End Sub

Then check what the highest value in col L, what is it?