VBA loop

[Cloris]

Hi, could someone know how to simplify into a loop? using For i = 1 To 4? it is just a sample, total number would until 59 .Thank you

Sub Macro()


'   Range("K3").Select
    ActiveCell.FormulaR1C1 = "1"
    Range("G5").Select
    Range(Selection, Selection.End(xlDown)).Select
    Selection.Copy
    Sheets("CrossMult_Validation").Select
    Range("B14").Select
    Selection.PasteSpecial Paste:=xlPasteValues, Operation:=xlNone, SkipBlanks _
        :=False, Transpose:=False
     
    Sheets("llustration").Select
    Range("K3").Select
    ActiveCell.FormulaR1C1 = "2"
    Range("G5").Select
    Range(Selection, Selection.End(xlDown)).Select
    Selection.Copy
    Sheets("CrossMult_Validation").Select
    Range("C14").Select
    Selection.PasteSpecial Paste:=xlPasteValues, Operation:=xlNone, SkipBlanks _
        :=False, Transpose:=False

    Sheets("llustration").Select
    Range("K3").Select
    Application.CutCopyMode = False
    ActiveCell.FormulaR1C1 = "3"
    Range("G5").Select
    Range(Selection, Selection.End(xlDown)).Select
    Selection.Copy
    Sheets("CrossMult_Validation").Select
    Range("D14").Select
    Selection.PasteSpecial Paste:=xlPasteValues, Operation:=xlNone, SkipBlanks _
        :=False, Transpose:=False

    Sheets("llustration").Select
    Range("K3").Select
    Application.CutCopyMode = False
    ActiveCell.FormulaR1C1 = "4"
    Range("G5").Select
    Range(Selection, Selection.End(xlDown)).Select
    Selection.Copy
    Sheets("CrossMult_Validation").Select
    Range("E14").Select
    Selection.PasteSpecial Paste:=xlPasteValues, Operation:=xlNone, SkipBlanks _
        :=False, Transpose:=False

End Sub

 

[maabadi]

Try this:

Sub Macro()
Dim WS1 As Worksheet, WS2 As Worksheet, i As Long
Set WS1 = Sheets("Sheet1")
Set WS2 = Sheets("Sheet2")
For i = 1 To 4
WS1.Range("K3").Value = i
WS1.Range("G5", WS1.Range("G5").End(xlDown)).Copy
WS2.Cells(14, i + 1).PasteSpecial Paste:=xlPasteValues
Next i
End Sub

 

[Cloris]

Try this:

Sub Macro()
Dim WS1 As Worksheet, WS2 As Worksheet, i As Long
Set WS1 = Sheets("Sheet1")
Set WS2 = Sheets("Sheet2")
For i = 1 To 4
WS1.Range("K3").Value = i
WS1.Range("G5", WS1.Range("G5").End(xlDown)).Copy
WS2.Cells(14, i + 1).PasteSpecial Paste:=xlPasteValues
Next i
End Sub

Hi, I hav error on this , WS2.Cells(14, i + 1).PasteSpecial Paste:=xlPasteValues, Operation:=xlNone, SkipBlanks _
:=False, Transpose:=False

May i know why? Thankyou in advance !

 

[maabadi]

1. I Edit code, use the last code
2. i always should be number. if i is number, what is error number that you see

 

[Cloris]

1. I Edit code, use the last code
2. i always should be number. if i is number, what is error number that you see

Thanks Maabadi, the problem solved.
Another ques,
May I know how to simplify this?

Sub Macro3()
'
    Range("D2").Select
    Sheets("Base").Select
    Cells.Select
    Selection.Copy
    Sheets("Base").Select
    Sheets.Add After:=Sheets(Sheets.Count)
    Cells.Select
    ActiveSheet.Paste
    Range("B5").Select
    Application.CutCopyMode = False
    ActiveCell.FormulaR1C1 = "=Input!R[-4]C[2]"
    Cells.Select
    Selection.Copy
    Selection.PasteSpecial Paste:=xlPasteValues, Operation:=xlNone, SkipBlanks _
        :=False, Transpose:=False
    ActiveSheet.Name = Range("B5").Value

End Sub

Can it simplify to like this?

Dim WS1 As Worksheet
Set WS1 =Sheets (“Base”)
WS1.Range("D2").Select
Cells.Select
Selection.Copy
WS1.Select
Sheets.Add After:=Sheets(Sheets.Count)
Cells.Select
ActiveSheet.Paste
Range("B5").Select
Application.CutCopyMode = False
ActiveCell.FormulaR1C1 = "=Input!R[-4]C[2]"
Cells.Select
Selection.Copy
Selection.PasteSpecial Paste:=xlPasteValues, Operation:=xlNone, SkipBlanks _
:=False, Transpose:=False
ActiveSheet.Name = Range("B5").Value

End Sub

Thankyou in advance Maabadi !

 

[maabadi]

Try this:

Sub Macro3()
    Sheets("Base").Copy After:=Sheets(Sheets.Count)
    Range("B5").Value = Sheets("Input").Range("D1").Value
    ActiveSheet.Name = Range("B5").Value
End Sub

When you write macro, you can remove select method, because 1. make your code slower, 2. you can join select line with selection line after that with removing select & selection