VBA Next without For Error

[Excel_GP]

I'm getting the Next without For error when trying to run the below macro. For some background, I want to search A1 of every worksheet to see if it contains the text string "- Placeholder" using the wildcard. If the worksheet contains that text string, I want to delete the worksheet. Appreciate any assistance and thanks in advance!

Sub deletesheetbycell()
'Delete Worksheets
Dim shName As String
Dim xName As String
Dim xWs As Worksheet
Dim cnt As Integer
Dim strName As String
Dim blnResult As Boolean

strName = "- Placeholder"

For Each xWs In ThisWorkbook.Sheets
With xWs.Range("A1")
If strName Like "*" & "- Placeholder" & "*" Then
blnResult = True
Else
blnResult = False
End If
If blnResult = True Then
xWs.Delete
cnt = cnt + 1
End If
Next xWs
Application.DisplayAlerts = True
End Sub

 

[Alex Blakenburg]

Please use the VBA button when you copy in the code or we have to manually spend time reformatting the code.
In fact reformatting your code makes it very obvious what is missing.
Here is your code reformatted with the missing End With added.

I haven't analysed the code, so come back to us if it is not doing what you need it to do.

Sub deletesheetbycell()
    'Delete Worksheets
    Dim shName As String
    Dim xName As String
    Dim xWs As Worksheet
    Dim cnt As Integer
    Dim strName As String
    Dim blnResult As Boolean
   
    strName = "- Placeholder"
   
    For Each xWs In ThisWorkbook.Sheets
        With xWs.Range("A1")
            If strName Like "*" & "- Placeholder" & "*" Then
                blnResult = True
            Else
                blnResult = False
            End If
            If blnResult = True Then
                xWs.Delete
                cnt = cnt + 1
            End If
        End With         ' Missing from original code
    Next xWs
    Application.DisplayAlerts = True
End Sub

 

[Excel_GP]

Thanks Rich. Much appreciated. The macro is still searching through the entire sheet instead of just A1 on each. Any insight? I assume it's obviously in the For Each section.

[
Sub deletesheetbycell()
    'Delete Worksheets
    Dim shName As String
    Dim xName As String
    Dim xWs As Worksheet
    Dim cnt As Integer
    Dim strName As String
    Dim blnResult As Boolean
   
    strName = "- Placeholder"
   
    For Each xWs In ThisWorkbook.Sheets
        With xWs.Range("A1")
            If strName Like "*" & "- Placeholder" & "*" Then
                blnResult = True
            Else
                blnResult = False
            End If
            If blnResult = True Then
                xWs.Delete
                cnt = cnt + 1
            End If
[B]      [/B]      End With
    Next xWs
    Application.DisplayAlerts = True
End Sub
]

 

[Alex Blakenburg]

At the moment you are not looking at A1 or in fact any other cell in the sheet nor are you doing anything with the With xWs.Range("A1") / End With structure.
If you are wanting to check if A1 contains what you have in strName try the below:

    For Each xWs In ThisWorkbook.Sheets
            If xWs.Range("A1") Like "*" & strName & "*" Then
                blnResult = True
            Else
                blnResult = False
            End If
            If blnResult = True Then
                xWs.Delete
                cnt = cnt + 1
            End If
    Next xWs